From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73552: obsolete (and broken) face attribute :reverse-video Date: Sun, 29 Sep 2024 15:55:02 +0300 Message-ID: <86ikue4o2h.fsf@gnu.org> References: <92B0B60A-A2A3-470B-A269-75531CA4FCE2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 73552@debbugs.gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 14:55:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sutSk-0008zh-J4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 14:55:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sutSZ-0000On-Hc; Sun, 29 Sep 2024 08:55:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sutSV-0000Oa-L2 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:55:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sutSU-000399-Du for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:55:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=nuAb33obkWDWB1KDMuOZsiqNLoyjMcJcYMCGro/t/Sw=; b=IIkmfQan5fayyrq+j82DLqkgfiNxDEsX8IcoEHU5nkBWrlysoj/hykU3PM90SDd4oxKviwXzo5kZ/e8tfRnrp+UCT1lq5dSZJxaA2KmssoEqYFoBLIpVfJxWbgg/Byi/y6t/uaBP6jpoiQF9fOEM6dZ4dw5MVwAa2ZaFKxDkoKLAqzkr/i8640a9Y/SsfFrAzb4KLP3ed/DhHyRK2p6qjLQ8YE7O5Ddg5L3LP5QsvbsEcYqfP6PFN5y53+o06kMfCa/N8nzf5SDVEhR3Wt2Wz04kYQSCeYkoawOAvxu3UzEDXany/R6XHhoOoupG/CtVqIckKZu+spBt9lB+dg9rQA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sutSz-00087v-Ml for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73552 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: gerd.moellmann@gmail.com, bug-gnu-emacs@gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.172761454131062 (code B ref -1); Sun, 29 Sep 2024 12:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Sep 2024 12:55:41 +0000 Original-Received: from localhost ([127.0.0.1]:40272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sutSe-00084l-KS for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:55:41 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sutSc-00082L-6e for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:55:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sutS6-0000Fy-KD for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:55:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sutS5-00035q-Ms; Sun, 29 Sep 2024 08:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nuAb33obkWDWB1KDMuOZsiqNLoyjMcJcYMCGro/t/Sw=; b=QWHKOqkUiYU7mFW/SDIZ sHo7nt9BzmXd4qmeArgGUpOt4QtE/JCGYOtzRU0X9bGn35N3ELGPz/J47MhBmnBU+Zm1YknsQbBkn SSGF8OWEMFNzVYRhHeYYdPP2WGPN8ousSKQ6tV1DJS+pc/jR0X6YG1JtD5I5nugiWpT9uzKNq5Hm0 W5cYDJ14cynTMj6apBtbimeJzp9Og5YGTpYZSJzbKbBy9LAV1POdo/YIVt50YI6xY+pnt9zZ8DW/J bxsMGSiukT16DQP9dvqM5PwrLmhnSwObQCq+44jMuc8D5ik8DotVIWLggg5lhnrmejIkrk7G6ZnjB +JylyK1dL7yrZw==; In-Reply-To: <92B0B60A-A2A3-470B-A269-75531CA4FCE2@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sun, 29 Sep 2024 14:35:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292638 Archived-At: > From: Mattias Engdegård > Date: Sun, 29 Sep 2024 14:35:01 +0200 > Cc: Emacs Bug Report , > Eli Zaretskii , > Stefan Monnier > > 29 sep. 2024 kl. 13.31 skrev Gerd Möllmann : > > >> I first blamed a simple 14 years old mistake in `custom-fix-face-spec` > >> but fixing that doesn't help, not sure why. > > Having said that I naturally had to find the bug and it appears to be `face-spec-set-2` which only sets attributes that are present in `face-x-resources` for some reason. > > > I'm pretty sure that I added :italic, :bold, :reverse-video to what > > later became Emacs 21 only for backwards compatibility with the old > > pre-21 face implementation. At least on the surface, because 21 faces > > work completely differently. (I also seem to remeber that reverse-video > > was a synonym for inverse-video in the old code, maybe even > > undocumented. > > Thanks. Given Gerd's testimony, the lack of use and general brokenness, I propose we just give up on :reverse-video, perhaps removing it from xfaces.c. I'm not sure I understand the proposal: we remove :reverse-video, but keep :inverse-video (which _is_ included in face-x-resources)? Or did you mean to remove :inverse-video as well?