From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74362: 31.0.50; Add completions for font names Date: Fri, 15 Nov 2024 14:24:34 +0200 Message-ID: <86iksoit19.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33378"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74362@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 15 13:25:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tBvOB-0008XQ-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Nov 2024 13:25:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBvNo-0002Bd-TO; Fri, 15 Nov 2024 07:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBvNn-00029p-BG for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2024 07:25:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBvNm-0002mq-Lv for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2024 07:25:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=oQ/SRx0cvP+6/TNqQ70hR9Hn4z1HWhrMEyVj8LwiqmQ=; b=AvdfbqEDc4IdA0ViVAh3y4zwPpFLXFzeM+byXM0szT03u/d2XURwCtEfjULPKOiz+oTANRJEqyea4P+Igl6XZHBKdreZ2qxTD6lUpANcrWo69001X6HPq5XsXEfzT3WPPBsbrQk7yH0KGZLLdJIUZUdZNJmMVbGKGZlQ0Uz/zxoPLAN9OCwQ8gKLvUCey5L6yKyQwi9wEVa4Xh93ppOd7qG6cGqJ5tdOj/uwcy3awUjPM8ChnRv8CeJvYn8nqg9kSxbqP7moaIlN1I0dUnN0Sd3+ywoL3CK72YKewQFj78L4CoBAjL6G5T2v0rtNnjyW1/Fe7NQBuOjOohUp5QWnQA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tBvNm-00028D-GB for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2024 07:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74362 X-GNU-PR-Package: emacs Original-Received: via spool by 74362-submit@debbugs.gnu.org id=B74362.17316734868163 (code B ref 74362); Fri, 15 Nov 2024 12:25:02 +0000 Original-Received: (at 74362) by debbugs.gnu.org; 15 Nov 2024 12:24:46 +0000 Original-Received: from localhost ([127.0.0.1]:48914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBvNV-00027Z-Pw for submit@debbugs.gnu.org; Fri, 15 Nov 2024 07:24:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBvNT-00027L-91 for 74362@debbugs.gnu.org; Fri, 15 Nov 2024 07:24:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBvNM-0002k3-GB; Fri, 15 Nov 2024 07:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oQ/SRx0cvP+6/TNqQ70hR9Hn4z1HWhrMEyVj8LwiqmQ=; b=VnYHI3jxuIJJ BfLrOQ99+a4CyfS9pbDkFlB9zyMpF+nJH8S+DtcBQVzDC0EIyrLsDyJAj3VLSAs/nYORg7x0rbVJj 9x2tkdSvGip7OCT1rnxNTEeDOCESGs1bphONXG23OLGkXwDCR5U4FC2z4P5Cfh2VyHH0R3hqBfgy7 BpDDNtRiosnD7XldtaWrbbFgjvMowgqKGswGkBrsgSGHTUi53IzIDzVQmxcYl77+hDz/r0fNaY86r PRXPX0Q/RDNrqruYJ/n7sCwpI5CkOemahvj/Rv94h447FJxl11V3+uVFd9ZwQFxdJ9A8pOtVZafAb pvyt3pD/0VQ3TMpkHZVfqQ==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295391 Archived-At: > Cc: monnier@iro.umontreal.ca > Date: Thu, 14 Nov 2024 17:48:54 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In the UI of `customize-face`, the font family name is the main one that > provides no help to fill it. > The simple patch below provides completion (I had to put the completion > function in `cus-edit.el` because of a circularity between > `cus-face.el` and `minibuffer.el` so we can't call > `completion-table-dynamic` while loading `cus-face.el`). > > Comments/objections? I suggest to try this on a system that has a lot of fonts installed, to make sure this doesn't slow down customize-face too much. In bug#74337 a user reported that font-family-list returned a list of no fewer than 10775(!) families. I wonder what will that do to this command. Also, the doc string of customize-face should be amended to say that it offers completion on fonts. Btw, how does one invoke completion on the face attributes which are supposed to provide one, such as weight or colors? M-C-i doesn't seem to do it for me, or what am I missing?