From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Mon, 18 Nov 2024 14:25:11 +0200 Message-ID: <86ikskvie0.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 13:26:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD0px-0004X2-5h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 13:26:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD0pd-0000AS-Cz; Mon, 18 Nov 2024 07:26:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD0pZ-00009n-8z for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:26:13 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD0pO-0002iD-RA for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:26:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=Lk1wT59IRxz6MG66LLRtcZVdu2qn3p31rj0vhK1dH7s=; b=Fw1C/8YllcVlXf9HUJjMxpDqFImA1zttT5lDDNeX65zgpGXlXF+LGeIYcjHZ5fz8b32NbQHJgy9fONfCGtOQ6Dq5GyOJUQ4bBHTVv6WhwOcKRIOxzDKGWY2JoPHEQ40ubm/WflRinUv4YC+/5YmdiD8LM4OBtloGo93z93lKbcQCRPScp9x+dInjbmq6DWtZzQEXmH74vQaDYWDe4qxC8MDVMJgVlj+PF08UT1WLYCAtLbSyQN/AikQto08w+cxa1cPbfftMdyxgZsuNXzN0cWfkUXPwOpmpez24mcm3ov9YR2bM7AcaFrgjxBb1Ofi4pdkpXUFK6nMEj3JOPq9T3w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD0pO-0007YF-Ln for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173193273228980 (code B ref 74361); Mon, 18 Nov 2024 12:26:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 18 Nov 2024 12:25:32 +0000 Original-Received: from localhost ([127.0.0.1]:60381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD0ot-0007XM-Rb for submit@debbugs.gnu.org; Mon, 18 Nov 2024 07:25:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD0os-0007X7-0b for 74361@debbugs.gnu.org; Mon, 18 Nov 2024 07:25:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD0ok-0002fm-5z; Mon, 18 Nov 2024 07:25:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Lk1wT59IRxz6MG66LLRtcZVdu2qn3p31rj0vhK1dH7s=; b=LCE9hbkrn6kf +wOV5oOFrdmiVucvPVSj16jFMo+V0oB89q3Aj13NgBsH/TOeUIspD3I5kasWE/COQJQ4+dY7yrs4W qKQQnMIVLAaC496Ib7DNZ+zM3zDGS/YVw9P8/dZGTPgDks1XkfNy6Ee2iLcFd/Mh3P0aoHbUkMcyg DSDr0i+5PfmyuiTvAKUnAHJq1/PGN0Pi63w6MMJ77cOw95NXL//o/ePj75ppENMkuHJY8cBtCRrTW xhBaudAm6+zFsyhS29NQUSBM1gY5ZDUbeMMh41JkM4n83ChcoBAxu9Jb3bnOyh3ay+YHJ9zDtG6cS 1mZOK/AH8b/uiFc8SMc6CA==; In-Reply-To: (message from Dmitry Gutov on Mon, 18 Nov 2024 03:42:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295590 Archived-At: > Date: Mon, 18 Nov 2024 03:42:34 +0200 > Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 16/11/2024 10:43, Eli Zaretskii wrote: > >> That's the term I would use both both, but maybe there could be better > >> wording. If xref-find-definition is not a navigation command, is it a > >> "search command"? > > Let me turn the table and ask: which Xref commands will NOT use this > > action, if we exclude commands like > > xref-find-definitions-other-window, which specify the window/frame to > > use? > > xref-query-replace-in-results will not (or its twin > xref-find-references-and-replace). I suppose not many people would > expect them to. This seems to indicate that my proposal is actually okay, since the above two commands do not "show results of Xref commands"? > Also, there is a nuance: when the Xref buffer itself is shown (i.e. when > there are multiple locations matching a xref-find-definitions search), > we're not going to pass (category . xref) to display-buffer either - it > is reserved for displaying the buffers of destination locations. And this is a separate issue, not related to the doc string?