From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74642: 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed Date: Thu, 05 Dec 2024 09:55:45 +0200 Message-ID: <86ikryy35q.fsf@gnu.org> References: <87wmgiy38x.fsf@163.com> <868qsy442u.fsf@gnu.org> <87ldwxy11t.fsf@163.com> <86ed2p2bgm.fsf@gnu.org> <87frn3yi04.fsf@163.com> <8634j31s75.fsf@gnu.org> <86ed2nz2jc.fsf@gnu.org> <878qsuy44r.fsf@163.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74642@debbugs.gnu.org To: Diancheng Wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 08:57:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ6jj-0000Lu-OF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 08:57:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ6jQ-00036w-EL; Thu, 05 Dec 2024 02:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ6jO-00036n-Vc for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:57:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ6jO-0005nX-Kf for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:57:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=eYqPkXDr6AwKawv4sHM/+Og+yD5rCyq3dJbuoyEMGag=; b=q3BCg4lV4OKk9qiqljnaRB7J9RVgShZzzI2+4+ItZBnocMVH7m9aNBcUrHYHuZEVWTiFa+etZLPfn52UhrbnL0Fteize7Ga6NCXE3wpmWHooMIIIv62RBw/fczd9GJkcI1M1rBDM2zQlTrrTU9V6sbDLs95m3P2P91Qr65APUyRLEBjQ8IRNZmLWiSZlXwtyJFg348pkUMKgQU1Z3G7Df/bcF7ar3TVLR4mH8MUp82k2Re9UjAoEpkJykT+5XoogMDs0o0hKyRKNIVBj8RbsJFldPnvQK5ibu+KWchXBo8Zr2RVeWid4LbwLaMImxZCopI0D7MHjj+VfNHNQqwdarg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ6jO-0006AD-7i for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 02:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74642 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74642-submit@debbugs.gnu.org id=B74642.173338538123621 (code B ref 74642); Thu, 05 Dec 2024 07:57:02 +0000 Original-Received: (at 74642) by debbugs.gnu.org; 5 Dec 2024 07:56:21 +0000 Original-Received: from localhost ([127.0.0.1]:38028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ6ii-00068u-JP for submit@debbugs.gnu.org; Thu, 05 Dec 2024 02:56:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ6ig-00068d-NF for 74642@debbugs.gnu.org; Thu, 05 Dec 2024 02:56:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ6ia-0005lI-IP; Thu, 05 Dec 2024 02:56:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eYqPkXDr6AwKawv4sHM/+Og+yD5rCyq3dJbuoyEMGag=; b=cIM32lSaiViT sDHL+inQP8my6XqNbyHcfmjbeBR1gL66NUteUCN8zBimYDHiK8xmiQtYV6D3JfKohB/k1vJOln0U0 oGNiwtMqCWVDrydoc7tvO5ckdojqC12MIuOVAbI5lPYpqc8vt7sdlFQqgmNBg98CasfWSbru3nl/u 9bkuVvHX47qIB0MuG80ZA43B69fx3Oa+2TeFb0UBrUx+m8v1cQ7qOFh7LghnMksYBWHDFIEoLJwff DEVd6671fDSc07Zy/2+m+miueHzyUbwOJk/clezAKm8RDRqCaA651c16rGfyke0Zm/PX12BUBqlbE Ta+TURN+vlr/FsIUkiIJUA==; In-Reply-To: <878qsuy44r.fsf@163.com> (message from Diancheng Wang on Thu, 05 Dec 2024 15:34:44 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296454 Archived-At: > From: Diancheng Wang > Cc: 74642@debbugs.gnu.org > Date: Thu, 05 Dec 2024 15:34:44 +0800 > > > Crystal ball says that the regression was caused by the change you > > submitted (and I installed) in bug#73687. It added a call to > > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel. > > Could you try reverting those changes and see if that solves the > > problem in Emacs 31? > > Yes, There is a regression in my patch: the arrow on the source line is > not stopped displaying when "*gud-myprogram" got killed. But Emacs 30 > and Emacs 31 still have another issue: > gud-highlight-current-line-overlay is not destroyed when > "*gud-myprogram*" got killed. As I already wrote, I don't see the problem in Emacs 30: when I kill the *gud-myprogram* buffer, the arrow disappears. > To reproduce it, you need to evaluate (setq > gud-highlight-current-line t). So in Emacs 30 this only happens when gud-highlight-current-line is non-nil? > I updated my patch to fix this 2 issues, see attachment. Does this fix the problem with the current-line indicator (either on the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31? Thanks.