From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Thu, 19 Dec 2024 10:36:54 +0200 Message-ID: <86ikrgkr15.fsf@gnu.org> References: <86wmi0g0x6.fsf@gnu.org> <11a86987cce9fe0a257c3fa58703dc33@finder.org> <86wmgl6jzv.fsf@gnu.org> <092cb755eee3a9b5e06d15c0b07e90b1@finder.org> <276414b03c24964aaeb9e43e8dba5e77@finder.org> <5fedec86bce470555814acbdf999f99d@finder.org> <86h6791khk.fsf@gnu.org> <09b0904da92efad899865b2ece5f3116@finder.org> <86ikrhm6zk.fsf@gnu.org> <868qsdlzt5.fsf@gnu.org> <8634ikncv8.fsf@gnu.org> <2aeb4a5f1e76879b874c88618beff37f@finder.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jared@finder.org, stefankangas@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org, rudalics@gmx.at To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 09:38:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOC33-0007mA-VE for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 09:38:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOC1l-0003ku-9x; Thu, 19 Dec 2024 03:37:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOC1i-0003dH-Se for emacs-devel@gnu.org; Thu, 19 Dec 2024 03:36:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOC1h-0005m3-Qs; Thu, 19 Dec 2024 03:36:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3E2/ld6+Bnowy+pjb7vQuPOmDGSj6Pmstv7ZLH4Zoy0=; b=F0gIOX+iF1lyxyUsVCYp 8H2NNpHPzH4KIZlbZBq1Oo3Rnr/SVSt0FebWNdIl+IO4rQUVYG18QyQslWv0b/PHK/262oA6/5X07 W/Y7hoBjeRuQm/w8ZXomC9vM1QNQfGjMGh61qlMUGP8ManwN/5aGHZIog50nUmGnEkPlJAvNAbF5+ uT/EnUhHCU+MO4rilc3XxVfFZzVmP/UtbRcA2NVRPrKtHjMHpvYbjJ06K+Jt94Iu/GIEjTFGFJIxm dcmBXDqoeniJAT1k3BX4ZPt5qteiGCj5AdOLHBykK+WNRGAejcNtSsKfM1xU6omGC/3PvnMS4Eigz dDF8lwVxAivYoQ==; In-Reply-To: (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Thu, 19 Dec 2024 06:30:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326705 Archived-At: > From: Gerd Möllmann > Cc: Eli Zaretskii , stefankangas@gmail.com, > acorallo@gnu.org, emacs-devel@gnu.org, rudalics@gmx.at > Date: Thu, 19 Dec 2024 06:30:23 +0100 > > And attached is what I came up today, with the help of a lot of coffee. > The changelog is a page worth of changelog entries, the diff is from > what I created these. As introductory text I'd use > > This changeset adds support for child frames on ttys. I'd say Add support for child frames on ttys (without the period). The ChangeLog part looks reasonable. My only comment is that you could collect changes with the same description together. For example, instead of * lisp/frame.el (frame-at): New function. (tty-frame-geometry): Declare C function. (tty-frame-edges): Declare C function. (tty-frame-list-z-order): Declare C function. (tty-frame-restack): Declare C function. (tty-display-pixel-height): Declare C function. (tty-display-pixel-width): Declare C function. you could use * lisp/frame.el (frame-at): New function. (tty-frame-geometry, tty-frame-edges, tty-frame-list-z-order) (tty-frame-restack, tty-display-pixel-height) (tty-display-pixel-width): Declare C function. But that's an optimization; what you have is perfectly okay. Thanks.