From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: assq_no_quit... huh? Date: Fri, 20 Dec 2024 09:41:56 +0200 Message-ID: <86ikrekdh7.fsf@gnu.org> References: <87zfkrp0da.fsf.ref@yahoo.com> <87zfkrp0da.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32324"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 20 08:43:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOXfX-0008E3-0X for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Dec 2024 08:43:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOXes-0002yx-Or; Fri, 20 Dec 2024 02:42:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOXeq-0002yY-3S for emacs-devel@gnu.org; Fri, 20 Dec 2024 02:42:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOXep-0005Sx-Ql; Fri, 20 Dec 2024 02:42:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HT4MYTZGkcc6085eyOpPG3mejyDBZVLmQNKqVtr0E5I=; b=pbPEfB1RBq5tSp6x14uN q39bgiAjYwzvZURR5GQhqWB8bkBY9ON+FgFjqsW7ll01H8E0dYVaRRF2t2Ry33t5b45zvtSCUrj/A zc4/OmD9EZpjD/LM9HW75qqfYfEONAL74mVE7rZDNb8x7f38T35ubBx+uP76nChVzWTw7IZO7Akl3 HbDEh9iSivi303IWENbPBCze4Iemtk07ZeOQ/YNiIIsbBD91SpdWuTUx3Gmes4Re6ZrXJisrf/oL3 w2ILSkUtvVHN2+QCrKFbqgVAlFfoHpI1ijaj1wmZL+AsSGZwZwPx09rXtuY6JKtraYAKBOoUGT/LM BdSaN2dlCUVUgA==; In-Reply-To: (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Fri, 20 Dec 2024 06:00:35 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326781 Archived-At: > From: Gerd Möllmann > Cc: emacs-devel@gnu.org > Date: Fri, 20 Dec 2024 06:00:35 +0100 > > Po Lu writes: > > > What's the meaning of this code? > > > > if (is_tty_frame (f)) > > { > > /* Ignore all invisble tty frames, children or root. */ > > if (!FRAME_VISIBLE_P (root_frame (f))) > > continue; > > > > /* Remember tty root frames which we've seen. */ > > if (!FRAME_PARENT_FRAME (f) > > && NILP (assq_no_quit (frame, tty_root_frames))) <=== > > tty_root_frames = Fcons (frame, tty_root_frames); > > } > > > > No alist is being constructed and consequently assq_no_quit always > > returns nil. > > Thanks, that's a bug. It would have better been memq_no_quit but that > doesn't seem to exist anymore. It did exist, in the w32*.c files. So the change you made to re-add memq_no_quit broke the MS-Windows build. Please in the future, when you add a new function, grep _all_ of the sources for the same symbol, to avoid inadvertent breakage of platforms where you don't build Emacs routinely. Thanks.