From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem Date: Tue, 03 Nov 2015 16:24:35 -0600 Message-ID: <86h9l2zpp8.fsf@stephe-leake.org> References: <86mvuv30i1.fsf@stephe-leake.org> <86y4ef16ha.fsf@stephe-leake.org> <86lhae27ib.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446589768 16150 80.91.229.3 (3 Nov 2015 22:29:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 22:29:28 +0000 (UTC) Cc: 21816@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 23:29:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ztk4m-0004wI-Le for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 23:29:12 +0100 Original-Received: from localhost ([::1]:51410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztk4m-0000vR-07 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 17:29:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztk4h-0000v6-Vo for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:29:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztk4c-0006yB-TT for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:29:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztk4c-0006y4-Pi for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ztk4c-0007Eh-Ez for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21816-submit@debbugs.gnu.org id=B21816.144658972327792 (code B ref 21816); Tue, 03 Nov 2015 22:29:02 +0000 Original-Received: (at 21816) by debbugs.gnu.org; 3 Nov 2015 22:28:43 +0000 Original-Received: from localhost ([127.0.0.1]:51954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ztk4I-0007EB-WA for submit@debbugs.gnu.org; Tue, 03 Nov 2015 17:28:43 -0500 Original-Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:42129) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1Ztk4G-0007E3-9Z for 21816@debbugs.gnu.org; Tue, 03 Nov 2015 17:28:41 -0500 Original-Received: (qmail 29959 invoked by uid 0); 3 Nov 2015 22:24:49 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 3 Nov 2015 22:24:49 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw2 with id dAQj1r01J2UdiVW01AQmuU; Tue, 03 Nov 2015 15:24:47 -0700 X-Authority-Analysis: v=2.1 cv=Jv9i8qIC c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=qtqOOiqGOCEA:10 a=S2_vNQ5VacWo3Pf7U_8A:9 a=Bm_gn1ICIww4tRPk:21 a=rYGfQ3m5HGkeuPWU:21 Original-Received: from [76.218.37.33] (port=65506 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1Ztk0T-00034t-9c; Tue, 03 Nov 2015 15:24:45 -0700 In-Reply-To: <86lhae27ib.fsf@stephe-leake.org> (Stephen Leake's message of "Tue, 03 Nov 2015 13:43:56 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108400 Archived-At: Stephen Leake writes: > You asked about "sorting xrefs"; the only sorting that is currently done > is in xref--analyze, which groups xrefs with the same filename. It uses > cl-assoc on the filename, which uses "equal" or "eq" for the string > comparison, I think. It does have a :test parameter we can use to > override that. > > So that could fail due to filename case sensitivity; I'll see if I can > construct an example. Here's a simple example: (let* ((xref1 (xref-make "(defvar foo" (xref-make-elisp-location 'xref-elisp-location 'define-var "c:/projects/emacs/master/lisp/progmodes/elisp-mode.el"))) (xref2 (xref-make "(defvar bar" (xref-make-elisp-location 'xref-elisp-location 'define-var "c:/Projects/emacs/master/lisp/progmodes/elisp-mode.el"))) (xref3 (xref-make "(defvar bar" (xref-make-elisp-location 'xref-elisp-location 'define-var "c:/projects/emacs/master/lisp/progmodes/elisp-mode.el"))) (alist1 (xref--analyze (list xref1 xref2))) (alist2 (xref--analyze (list xref1 xref3)))) (list (length alist1) (length alist2)) ) returns (2 1); xref1 and xref2 are not grouped, because the file names compare not equal. If xref-make-elisp-location used file-truename, this problem would be fixed: (let* ((xref1 (xref-make "(defvar foo" (xref-make-elisp-location 'xref-elisp-location 'define-var (file-truename "c:/projects/emacs/master/lisp/progmodes/elisp-mode.el")))) (xref2 (xref-make "(defvar bar" (xref-make-elisp-location 'xref-elisp-location 'define-var (file-truename "c:/Projects/emacs/master/lisp/progmodes/elisp-mode.el")))) (xref3 (xref-make "(defvar bar" (xref-make-elisp-location 'xref-elisp-location 'define-var (file-truename "c:/projects/emacs/master/lisp/progmodes/elisp-mode.el")))) (alist1 (xref--analyze (list xref1 xref2))) (alist2 (xref--analyze (list xref1 xref3)))) (list (length alist1) (length alist2)) ) returns (1 1) -- -- Stephe