From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: change in call-next-method
Date: Sun, 03 Jan 2016 05:38:40 -0600 [thread overview]
Message-ID: <86h9iuc2o4.fsf@stephe-leake.org> (raw)
I'm updating JDEE to Emacs 25. It has several functions like this:
(cl-defmethod initialize-instance ((this jdee-jddocset) &rest rest)
(apply 'call-next-method rest)
(unless (oref this description)
(oset this :description
(if (oref this jdkp)
(format "JDK %s Javadoc" (oref this version))
(let ((file (jdee-url-file (oref this url))))
(if (string-match ".*\\/\\(.*?\\)\\/doc\\/api" file)
(match-string 1 file)
(jdee-url-name (oref this url))))))))
This breaks if I just change call-next-method to cl-call-next-method. In
Emacs 24, `call-next-method' is a defun that does the right thing here
(calls the default superclass init). In Emacs 25, cl-call-next-method is
a defun that throws an error; cl-defmethod is supposed to replace plain
calls to cl-call-next-method with an in-line call to the appropriate
method.
As far as I can tell, the only reason for the call to call-next-method
is to process the constructor args in `rest', storing them in the
appropriate slots.
What is the right way to do that in Emacs 25? I don't see anything in
the CL manual about this, and I can't find the relevant code by reading
the implementations of cl-defmethod or cl-generic.
--
-- Stephe
next reply other threads:[~2016-01-03 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 11:38 Stephen Leake [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-03 11:37 change in call-next-method Stephen Leake
2016-01-03 12:06 ` Andreas Schwab
2016-01-03 13:43 ` Stephen Leake
2016-01-03 14:48 ` Eric Abrahamsen
2016-01-03 18:05 ` Stephen Leake
2016-01-03 21:48 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h9iuc2o4.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.