Re: master 158bb85 1/2: Fix issues regarding inotify file-notification

Re: master 158bb85 1/2: Fix issues regarding inotify file-notification

[Lars Brinkhoff]

Michael.Albinus@gmx.de wrote:
> Fix issues regarding inotify file-notification
> 
> Remove special code handling the inotify back-end.
> * lisp/filenotify.el (file-notify--watch): New struct
> representing a file-watch.
> ...

This commits adds a new testsuite failure when I run
git clean -xfd && ./autogen.sh && make bootstrap && make check

There's a new check in Finotify_add_watch that `Qdont_follow' is not a
member of `aspect'.  But `aspect' may be either a list or a symbol.  The
check fails when the testsuite passes in `t'.


From test/src/inotify-tests.log:

Test inotify-file-watch-simple backtrace:
  (let ((temp-file (make-temp-file "inotify-simple")) (events 0)) (let
  (closure (t) nil (let ((fn-0 (function featurep)) (args-1 (list (quo
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test inotify-file-watch-simple "Test if
  ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
  ert-run-tests((not (tag :expensive-test)) #[385 "\306^B\307\"\203G^@\2
  ert-run-tests-batch((not (tag :expensive-test)))
  ert-run-tests-batch-and-exit((not (tag :expensive-test)))
  eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
  command-line-1(("-L" ":." "-l" "ert" "-l" "src/inotify-tests.el" "--
  command-line()
  normal-top-level()
Test inotify-file-watch-simple condition:
    (wrong-type-argument listp t)
   FAILED  1/1  inotify-file-watch-simple

Re: master 158bb85 1/2: Fix issues regarding inotify file-notification

[Michael Albinus]

Lars Brinkhoff <lars@nocrew.org> writes:

Hi Lars,

> This commits adds a new testsuite failure when I run
> git clean -xfd && ./autogen.sh && make bootstrap && make check
>
> There's a new check in Finotify_add_watch that `Qdont_follow' is not a
> member of `aspect'.  But `aspect' may be either a list or a symbol.  The
> check fails when the testsuite passes in `t'.

Should be fixed now in master.

Best regards, Michael.

Re: master 158bb85 1/2: Fix issues regarding inotify file-notification

[Lars Brinkhoff]

Michael Albinus wrote:
> Lars Brinkhoff <lars@nocrew.org> writes:
>> This commits adds a new testsuite failure when I run
>> git clean -xfd && ./autogen.sh && make bootstrap && make check
>>
>> There's a new check in Finotify_add_watch that `Qdont_follow' is not a
>> member of `aspect'.  But `aspect' may be either a list or a symbol.  The
>> check fails when the testsuite passes in `t'.
>
> Should be fixed now in master.

Yes, that looks good.  Thanks!