From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Tue, 04 Sep 2018 20:56:54 +0100 Message-ID: <86h8j5f33t.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536091445 15532 195.159.176.226 (4 Sep 2018 20:04:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 20:04:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 22:04:01 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxHYL-0003nY-Jm for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 22:03:57 +0200 Original-Received: from localhost ([::1]:52454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHaR-0003hv-Q8 for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 16:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHZg-0003TT-Q9 for emacs-devel@gnu.org; Tue, 04 Sep 2018 16:05:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxHRi-0003qa-31 for emacs-devel@gnu.org; Tue, 04 Sep 2018 15:57:11 -0400 Original-Received: from [195.159.176.226] (port=59746 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxHRg-0003p4-Jr for emacs-devel@gnu.org; Tue, 04 Sep 2018 15:57:04 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fxHPW-0006UU-8u for emacs-devel@gnu.org; Tue, 04 Sep 2018 21:54:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:UtPXvWi+ZvIvLTL28OuO52FXoEk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229260 Archived-At: On Tue 04 Sep 2018, Andy Moreton wrote: > On Tue 04 Sep 2018, Paul Eggert wrote: > >> Andy Moreton wrote: >> >>> The recent changes in commit fe042e9d ("Speed up (+ 2 2) by a factor of >>> 10") cause an immediate crash in 64bit emacs on Windows. >> >> Thanks for reporting it. Please try the attached patch, which I installed on master. > > Thanks - that fixes the crash, so Eli's crystal ball is working well. I now see a strange warning on 64bit Windows (building with gcc 8.2.0 for target x86_64-w64-mingw32): CC data.o In file included from C:/emacs/git/emacs/master/src/data.c:31: C:/emacs/git/emacs/master/src/data.c: In function 'arith_driver': C:/emacs/git/emacs/master/src/lisp.h:2479:34: warning: 'accum' may be used uninitialized in this function [-Wmaybe-uninitialized] return FIXNUM_OVERFLOW_P (n) ? make_bigint (n) : make_fixnum (n); ^~~~~~~~~~~~~~~ C:/emacs/git/emacs/master/src/data.c:2962:12: note: 'accum' was declared here intmax_t accum = XFIXNUM (val); ^~~~~