From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: nadvice compatibility in package list Date: Sat, 06 Jul 2019 19:15:20 +0100 Message-ID: <86h87z2fnr.fsf@gmail.com> References: <864l3z2pux.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238520"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 06 20:16:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjpEP-000zvi-3P for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2019 20:16:17 +0200 Original-Received: from localhost ([::1]:60840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjpEN-0001tR-RL for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2019 14:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59722) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjpDd-0001sf-0T for emacs-devel@gnu.org; Sat, 06 Jul 2019 14:15:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjpDc-0001Th-6W for emacs-devel@gnu.org; Sat, 06 Jul 2019 14:15:28 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:43024 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hjpDb-0001SE-Vm for emacs-devel@gnu.org; Sat, 06 Jul 2019 14:15:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hjpDZ-000yxn-Br for emacs-devel@gnu.org; Sat, 06 Jul 2019 20:15:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:UQmzSsVlWFO+ugn2WpT/9euos1w= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238381 Archived-At: On Sat 06 Jul 2019, Stefan Monnier wrote: >> Stefan, your patch gives the right assoc lookups, but does not show the >> builtin nadvice package in the output from `list-packages'. > > Hmm... it does for me: `src/emacs -Q` followed by `M-x list-packages` > followed by `C-s nadvice C-s C-s` puts me on the line: > > nadvice 1.0 built-in Light-weight advice primitives for Elisp functions > >> To test each patch I deleted lisp/finder-inf.el before rebuilding. >> Let me know if this is insufficient for a correct rebuild. > > Hmm... maybe finder-inf.el was rebuilt before finder.el was recompiled > and it used a stale finder.elc? > Could you double check? After a full bootstrap, your patch does work. AndyM