From: Juri Linkov <juri@linkov.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>,
Eli Barzilay <eli@barzilay.org>,
21634@debbugs.gnu.org
Subject: bug#21634: text-scale-adjust suggestion
Date: Wed, 06 Jul 2022 20:42:20 +0300 [thread overview]
Message-ID: <86h73uqs1j.fsf@mail.linkov.net> (raw)
In-Reply-To: <87a69nitkk.fsf@gmail.com> (Robert Pluim's message of "Tue, 05 Jul 2022 15:21:15 +0200")
> >> format-spec is a nice helper. Here are the changes after
> >> the value of %k is automatically generated from the keys:
> >>
> >> emoji-zoom-increase:
> >> OLD: Zoom with + and -
> >> NEW: Zoom with +, -
> >>
> >> indent-rigidly:
> >> OLD: Indent region with <left>, <right>, S-<left>, or S-<right>.
> >> NEW: Indent region with TAB, <left>, <right>, S-<left>, S-<right>
>
> Lars> I think the final ", " in these lists should be an " or " instead -- I
> Lars> think that reads better.
>
> Yes
Should then describe-repeat-maps do the same and replace this
next-error (bound to n, M-n)
previous-error (bound to p, M-p)
with
next-error (bound to n or M-n)
previous-error (bound to p or M-p)
Then also should repeat-echo-message-string use "or" and replace
Repeat with n, M-n
with
Repeat with n or M-n
But doing this is problematic since when repeat-exit-key is defined,
it will also replace
Repeat with n, M-n or exit with RET
with incorrect
Repeat with n or M-n or exit with RET
> >> global-text-scale-adjust:
> >> OLD: Use +,-,0 for further adjustment
> >> NEW: Use +, =, -, 0, ESC for further adjustment
> >>
> >> ESC is because map-keymap handles only top-level keys
> >> but C-M-+ is [ESC C-+].
>
> Lars> Hm. We don't have any function that'll just spit out all the "real" key
> Lars> binding in a keymap somewhere? I.e., that results in a list with keys a
> Lars> la what's displayed by `C-h b'? I guess not, but that sounds like a
> Lars> useful utility function to have, and could be used here.
>
> I think the guts of `describe-repeat-mapsʼ does something like that.
I forgot that describe-repeat-maps uses where-is-internal.
But I don't see how repeat-echo-message-string and set-transient-map
could use where-is-internal without iterating a huge list of all commands
from obarray. There is no function to get all commands from the given
keymap only?
BTW, now I fixed describe-repeat-maps to handle the case when the
keymap is not a symbol, e.g.
(put 'next-line 'repeat-map (define-keymap
"C-M-a" #'next-line
"C-M-b" #'next-line))
Also pushed new args of set-transient-map, so the same improvements
are needed for both repeat-echo-message-string and set-transient-map,
maybe by sharing the same code.
next prev parent reply other threads:[~2022-07-06 17:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:04 bug#21634: 24.5; Suggested improvement Eli Barzilay
2015-10-06 14:58 ` Eli Zaretskii
2015-10-22 6:06 ` Eli Barzilay
2015-10-23 8:24 ` Eli Zaretskii
2021-09-03 11:02 ` bug#21634: text-scale-adjust suggestion Lars Ingebrigtsen
2021-09-03 16:13 ` Juri Linkov
2021-09-04 6:54 ` Lars Ingebrigtsen
2021-09-05 16:40 ` Juri Linkov
2021-09-06 8:28 ` Lars Ingebrigtsen
2021-09-06 15:34 ` Juri Linkov
2021-09-06 22:15 ` bug#21634: [External] : " Drew Adams
2021-09-06 22:31 ` Eli Barzilay
2021-09-06 22:35 ` Drew Adams
2021-09-07 8:16 ` martin rudalics
2022-06-30 16:12 ` Juri Linkov
2022-07-01 9:17 ` Lars Ingebrigtsen
2022-07-01 15:40 ` Juri Linkov
2022-07-02 11:59 ` Lars Ingebrigtsen
2022-07-03 16:36 ` Juri Linkov
2022-07-04 10:51 ` Lars Ingebrigtsen
2022-07-04 17:45 ` Juri Linkov
2022-07-05 11:15 ` Lars Ingebrigtsen
2022-07-05 13:21 ` Robert Pluim
2022-07-05 16:38 ` Lars Ingebrigtsen
2022-07-05 16:39 ` Lars Ingebrigtsen
2022-07-06 17:42 ` Juri Linkov [this message]
2022-07-07 8:01 ` Lars Ingebrigtsen
2022-07-07 16:49 ` Juri Linkov
2022-07-07 18:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h73uqs1j.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=21634@debbugs.gnu.org \
--cc=eli@barzilay.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.