From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Tue, 25 Apr 2023 20:30:54 +0300 Organization: LINKOV.NET Message-ID: <86h6t3q3nt.fsf@mail.linkov.net> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34505"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 62427@debbugs.gnu.org To: Benson Chu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 25 19:38:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prMcT-0008oD-0C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Apr 2023 19:38:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prMcE-0003C0-7X; Tue, 25 Apr 2023 13:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prMc7-00033n-IL for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 13:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prMc6-00062f-5e for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 13:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1prMc6-0005kn-11 for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Apr 2023 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168244424122060 (code B ref 62427); Tue, 25 Apr 2023 17:38:01 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 25 Apr 2023 17:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:53517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbR-0005jj-Bb for submit@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:21 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:50359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbM-0005jA-8a for 62427@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:16 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4E1B5240002; Tue, 25 Apr 2023 17:37:08 +0000 (UTC) In-Reply-To: <86lejajex8.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 02 Apr 2023 21:51:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260634 Archived-At: >> 1. (setq debug-on-error t enable-recursive-minibuffers t) >> 2. M-: (or any other prompt like 'M-x') >> 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high >> 4. M-x windmove-swap-states-up RET >> 5. Click on the bottom window >> 6. C-x t 2 >> 7. Click on the bottom window >> 8. C-x t 2 >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >> delete-other-windows-internal(# #) >> delete-other-windows() >> tab-bar-new-tab-to() >> tab-new(nil) > > Maybe the simplest fix is just not to create such a broken > window configuration: > > diff --git a/lisp/windmove.el b/lisp/windmove.el > index 06ce16c0d42..57511291588 100644 > --- a/lisp/windmove.el > +++ b/lisp/windmove.el > @@ -724,6 +724,8 @@ windmove-swap-states-in-direction > nil windmove-wrap-around 'nomini))) > (cond ((or (null other-window) (window-minibuffer-p other-window)) > (user-error "No window %s from selected window" dir)) > + ((window-minibuffer-p (selected-window)) > + (user-error "Selected window is the minibuffer")) > (t > (window-swap-states nil other-window))))) This is another patch that could be installed either to emacs-29 or master.