From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames Date: Mon, 29 Jan 2024 14:37:03 +0200 Message-ID: <86h6iw48pc.fsf@gnu.org> References: <20230422102146.93003-1-mohkale@kisara.moe> <86le89itke.fsf@kisara.moe> <86a5op64tv.fsf@gnu.org> <86fryg62kh.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 29 13:38:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUQtu-0001s3-2t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jan 2024 13:38:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUQtf-0005Uk-KY; Mon, 29 Jan 2024 07:37:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUQte-0005TS-38 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 07:37:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUQtd-0001PS-Qr for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 07:37:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUQtm-0007l9-26 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 07:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2024 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.170653184229782 (code B ref 62994); Mon, 29 Jan 2024 12:38:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 29 Jan 2024 12:37:22 +0000 Original-Received: from localhost ([127.0.0.1]:59232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUQt7-0007kH-TZ for submit@debbugs.gnu.org; Mon, 29 Jan 2024 07:37:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUQt5-0007k4-AY for 62994@debbugs.gnu.org; Mon, 29 Jan 2024 07:37:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUQsr-0001K7-MK; Mon, 29 Jan 2024 07:37:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MIaNbvVpEYAxacRgHckWL1prBwCeB7PlfcTFoY91MCQ=; b=UyZZz/j6GQ3Z /h3We3sPIqnaKu5nBwjn73hiQ1mo7Ygx4Rrvsj51Qs+wERKj8rP/L0Ks5rJbTl00eMbBg25xBmK2e ONc4LnhhzWnVRW7kvoTTN6rv0KK3WbHcoC4xMmYBmc+CLTP+pIRrj5zuU94n+nnrR832Wzk7rAlUn lCDZRGGhmP6+I12SZ1L9kAu25hLgKxVmrqiHQw4EosnYzdCmdabLmkn7k6wBuhh0o8no3qz68grrj ywFrH3q1FKuJ/btzPge3qV4gZnKPyvyVhxBHcIcIcMUc0vLZRSxGYGytkfU3hZke/mbra16zSYgbj wlL6vcuusp4B7RboJep9uA==; In-Reply-To: <86fryg62kh.fsf@kisara.moe> (message from Mohsin Kaleem on Mon, 29 Jan 2024 08:06:38 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279125 Archived-At: [Please use Reply All to reply, to keep the bug tracker CC'ed.] > From: Mohsin Kaleem > Date: Mon, 29 Jan 2024 08:06:38 +0100 > > Eli Zaretskii writes: > > > The MSDOS frames are different from other TTY frames in that we can > > know the default colors used by the MSDOS terminals. That's why MSDOS > > needs a special code there. And yes, we want to keep this logic, for > > MSDOS only. > > Interesting. Didn't know MSDOS terminals expose that. Neat. Although why > do we update the face spec (face->lface) itself in this case instead of > only the foreground/background values which we do later anyways. AFAIR, it's because those default colors are then used to define the 'default' face and the frame's fore/back-ground pixel values, so we need the actual colors. > face->lface seems to be the actual spec set in the theme/customisation > display (unless I'm misunderstanding). If we change it wouldn't that > alter what's shown in customize for example. How can that alter what is shown, when the colors we stick in the face are the exact colors that the screen uses? It's like you take a "blue" color that is specified by the special name "default" and replace it with an actual "blue" -- how can the result be different.