From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Thu, 08 Feb 2024 08:03:59 +0200 Message-ID: <86h6ijxzjk.fsf@gnu.org> References: <871q9rvqbi.fsf@jeremybryant.net> <87mssc65y8.fsf@posteo.net> <87y1bwrll4.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 07:05:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXxWx-0000Po-QC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 07:05:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXxWk-0007z3-1D; Thu, 08 Feb 2024 01:04:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXxWi-0007yu-Ek for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:04:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXxWi-0007l9-6N for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:04:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXxWw-0008Rw-BY for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 06:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.170737226732436 (code B ref 68929); Thu, 08 Feb 2024 06:05:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 8 Feb 2024 06:04:27 +0000 Original-Received: from localhost ([127.0.0.1]:58820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXxWN-0008R6-3C for submit@debbugs.gnu.org; Thu, 08 Feb 2024 01:04:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXxWL-0008Qs-2R for 68929@debbugs.gnu.org; Thu, 08 Feb 2024 01:04:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXxW0-0007jL-8Q; Thu, 08 Feb 2024 01:04:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SIgXPSdWG1206wsFJHvqx6ltRaxFCnLdsCpJ4pfUNGY=; b=DIHyknZqu3sf QB//JY6DAWZ5D8XfXRBYf/a6N1OSrq4EINh/OtYr5rEIn/GMwWpP8MxlXylI8ADxyphS7XZSIwBVt Yma6Lwsihxyc+1lLpzDhh0yOjOuUYQvXCYG81ePD+upljfbow2ZDXTqFohzOuORmZQd4r4WfBw6Cw D5KPM3PDws/DF9meQJiCD2dDpnyQtec+QbOSIcR1s0n2kDd9PbIdixM/RLAFgv8tZXuMN3m49Xod5 o48u7qLTAzSlxYOeLbOcrfKQfTACp5E3bx8ZyD+kjbLJ4rmNemBPQk5B+cx2CvpJSdtas67Ye/yR6 IDvlyWEiEkDls9sHb4EOPQ==; In-Reply-To: <87y1bwrll4.fsf@jeremybryant.net> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279596 Archived-At: > Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc > Date: Wed, 07 Feb 2024 21:48:00 +0000 > From: Jeremy Bryant via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Philip Kaludercic writes: > > > My genera feeling is that the code is reinventing the wheel at a number > > of places, which might make it more complicated to maintain in the long > > term. Looking for ways to slim down the codebase, perhaps by > > deprecating some options, dropping support for third-party packages and > > reusing existing functionality seems like something one should look into. > > Should these improvements be made before moving which-key to core? Preferably, yes.