From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Thu, 08 Feb 2024 18:54:24 +0200 Message-ID: <86h6iix5fj.fsf@gnu.org> References: <871q9rvqbi.fsf@jeremybryant.net> <86wmrj148c.fsf@gnu.org> <87plx8rkps.fsf@jeremybryant.net> <86cyt7xyy7.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jb@jeremybryant.net, 68929@debbugs.gnu.org, justin@burkett.cc To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 17:55:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rY7g8-0000rR-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 17:55:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rY7fn-0001g0-DQ; Thu, 08 Feb 2024 11:54:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY7fl-0001fo-Gl for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 11:54:50 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rY7fk-000178-6s for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 11:54:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rY7fy-0006BH-9s for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 11:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.170741129223740 (code B ref 68929); Thu, 08 Feb 2024 16:55:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 8 Feb 2024 16:54:52 +0000 Original-Received: from localhost ([127.0.0.1]:33519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY7fo-0006Aq-7Q for submit@debbugs.gnu.org; Thu, 08 Feb 2024 11:54:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY7fm-0006Ae-KD for 68929@debbugs.gnu.org; Thu, 08 Feb 2024 11:54:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY7fP-00016a-MN; Thu, 08 Feb 2024 11:54:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sNQ/1FF9fdX+OFa7IqGKNYZ+UufCePnqN32+Vp2g+eY=; b=QIL/2MtKp8Et V0/tIN+ALK8P8C1FbFNtjpmp9rJ63uZhmuwriPIMvk+R9Wi0BMCTjg3HGIABI8E8ZqZ8OA4g0v19z TAavtCMhfaZxq8eS2N32ajCmOycxz+lCRKMTAzD1V9EaRlJHPrxTd4b9oSqhYEn3n+7v5wF08RD9n NllXTICvhoFiSZUaovlqIt8G5vS2Vx3ENv3e2VtxxUPaz8cr6MtTluIF48o+Hzje7OEX9NYeZqezW Cx3MUJ4Lwm+2OvFgFq9jMlC44H5KH/ddGPT57jJ3FZtycNe3+kNWv3uZLm1njow3OSHYG2/kZAGRK CgO7DDF+WFYH5Someu1tuQ==; In-Reply-To: (message from Stefan Monnier on Thu, 08 Feb 2024 11:10:44 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279646 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , Jeremy Bryant , > 68929@debbugs.gnu.org > Date: Thu, 08 Feb 2024 11:10:44 -0500 > > > 4. I never really liked the timer mechanism either, but I didn't find > > an alternative to detecting when emacs was in the middle of reading a > > key sequence. I like the idea of which-key as simply being a different > > describe-prefix-bindings function, but my sense is that novices > > appreciate the automatic popup. I'm wondering if anyone has any other > > ideas. In principle, one could have a hook that emacs uses to notify > > which-key that emacs is waiting on a key sequence, but maybe that is > > overkill. > > I don't have a strong opinion about the use of a timer. > But maybe we could hook into the `echo-keystrokes` mechanism (and thus > reuse its timer, which also defaults to 1s). Yes, that'd be the first possibility I'd recommend to explore.