From: Juri Linkov <juri@linkov.net>
To: 69983@debbugs.gnu.org
Cc: martin rudalics <rudalics@gmx.at>
Subject: bug#69983: Use category for display-buffer-alist
Date: Sun, 24 Mar 2024 19:19:16 +0200 [thread overview]
Message-ID: <86h6gv7e0z.fsf@mail.linkov.net> (raw)
'display-comint-buffer-action' and 'display-tex-shell-buffer-action'
are out of place in window.el, and they are redundant per se.
What these variables are trying to achieve is already possible
to do by using a 'category' in 'display-buffer-alist'.
Here is an already supported example:
#+begin_src emacs-lisp
(add-to-list 'display-buffer-alist
`(,(lambda (_buffer-name action)
(eq (alist-get 'category action) 'comint))
(display-buffer-in-direction)
(direction . top)))
(display-buffer (get-buffer-create "blablabla")
'(nil (category . comint)))
#+end_src
The advantage of this approach is removing a need
of writing a complex regexp to match the buffer name.
Using this approach it's possible just to mark
all related callers with the same category, e.g.:
diff --git a/lisp/cmuscheme.el b/lisp/cmuscheme.el
index c84a1809322..ccd7f2f713f 100644
--- a/lisp/cmuscheme.el
+++ b/lisp/cmuscheme.el
@@ -238,7 +238,7 @@ run-scheme
(inferior-scheme-mode)))
(setq scheme-program-name cmd)
(setq scheme-buffer "*scheme*")
- (pop-to-buffer "*scheme*" display-comint-buffer-action))
+ (pop-to-buffer "*scheme*" '(nil (category . comint))))
diff --git a/lisp/progmodes/inf-lisp.el b/lisp/progmodes/inf-lisp.el
index 141bd18cf1e..1aa3bbd4239 100644
--- a/lisp/progmodes/inf-lisp.el
+++ b/lisp/progmodes/inf-lisp.el
@@ -308,7 +308,7 @@ inferior-lisp
"inferior-lisp" (car cmdlist) nil (cdr cmdlist)))
(inferior-lisp-mode)))
(setq inferior-lisp-buffer "*inferior-lisp*")
- (pop-to-buffer "*inferior-lisp*" display-comint-buffer-action))
+ (pop-to-buffer "*inferior-lisp*" '(nil (category . comint))))
Or we need to keep backward-compatibility? Then the first step
to deprecate there variables would be something like this:
diff --git a/lisp/window.el b/lisp/window.el
index bea050e181c..fa417817d1d 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8912,7 +8944,7 @@ pop-to-buffer-same-window
another window."
(pop-to-buffer buffer display-buffer--same-window-action norecord))
-(defcustom display-comint-buffer-action display-buffer--same-window-action
+(defcustom display-comint-buffer-action (append display-buffer--same-window-action '((category . comint)))
"`display-buffer' action for displaying comint buffers."
:type display-buffer--action-custom-type
:risky t
next reply other threads:[~2024-03-24 17:19 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 17:19 Juri Linkov [this message]
2024-03-25 9:41 ` bug#69983: Use category for display-buffer-alist martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:12 ` Juri Linkov
2024-03-26 9:55 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 7:15 ` Juri Linkov
2024-03-28 7:47 ` Juri Linkov
2024-03-28 8:23 ` Eli Zaretskii
2024-03-28 17:46 ` Juri Linkov
2024-03-28 9:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:50 ` Juri Linkov
2024-03-29 8:43 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:30 ` Juri Linkov
2024-03-30 9:36 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:22 ` Juri Linkov
2024-04-02 16:52 ` Juri Linkov
2024-04-04 6:16 ` Juri Linkov
2024-04-05 16:47 ` Juri Linkov
2024-04-06 18:42 ` Juri Linkov
2024-04-07 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 6:30 ` Juri Linkov
2024-04-09 7:09 ` Eli Zaretskii
2024-04-09 16:34 ` Juri Linkov
2024-04-09 18:28 ` Eli Zaretskii
2024-04-10 6:45 ` Juri Linkov
2024-04-10 8:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 11:07 ` Eli Zaretskii
2024-04-10 17:49 ` Juri Linkov
2024-04-10 18:13 ` Eli Zaretskii
2024-04-11 6:31 ` Juri Linkov
2024-04-11 7:40 ` Eli Zaretskii
2024-04-12 6:37 ` Juri Linkov
2024-04-12 7:05 ` Eli Zaretskii
2024-04-12 16:50 ` Juri Linkov
2024-04-12 18:27 ` Eli Zaretskii
2024-04-13 18:49 ` Juri Linkov
2024-04-13 19:03 ` Eli Zaretskii
2024-04-14 16:04 ` Juri Linkov
2024-04-18 14:30 ` Eli Zaretskii
2024-04-18 17:16 ` Juri Linkov
2024-04-18 17:56 ` Eli Zaretskii
2024-04-19 6:24 ` Juri Linkov
2024-04-19 6:28 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-19 16:17 ` Juri Linkov
2024-04-20 12:08 ` Eli Zaretskii
2024-04-21 6:52 ` Juri Linkov
2024-04-21 9:13 ` Eli Zaretskii
2024-04-22 6:50 ` Juri Linkov
2024-04-19 7:19 ` Eli Zaretskii
2024-04-11 9:16 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-11 11:03 ` Eli Zaretskii
2024-04-24 16:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6gv7e0z.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69983@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.