From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS native subrs (was: MPS make-thread) Date: Wed, 26 Jun 2024 16:26:29 +0300 Message-ID: <86h6df96nu.fsf@gnu.org> References: <87v823xvq1.fsf@localhost> <87tthm3gq2.fsf@gmail.com> <87sex6ags5.fsf@localhost> <87msne3flr.fsf@gmail.com> <87frt63dvt.fsf@gmail.com> <86o77ulgk8.fsf@gnu.org> <87zfre1p3r.fsf@gmail.com> <87zfreo5u6.fsf@localhost> <87plsa1n8k.fsf@gmail.com> <87wmmio3vq.fsf@localhost> <87jzii1hbs.fsf_-_@gmail.com> <8734p61evv.fsf@gmail.com> <87iky0zvyz.fsf@gmail.com> <87ikxwamor.fsf_-_@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Helmut Eller , Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 26 15:27:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMSg6-0002jj-Kv for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Jun 2024 15:27:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMSfX-00079j-RB; Wed, 26 Jun 2024 09:26:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMSfS-00076B-Ia for emacs-devel@gnu.org; Wed, 26 Jun 2024 09:26:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMSfR-0002BW-3l; Wed, 26 Jun 2024 09:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1qinN3YVXLma/gD8XgCbyrIzhlsA3Xs3osdB9StLr8I=; b=Kfc4coNsksjO AiorETklVTpfrzdVXONwaGjVQ2A3xFBztCBQpbVRQh+uJzN/L/M5PuNcWAbTPwlgdGTVGoypbzRMZ n4NfZEPqkMwhetsEGCKe8rxxcTJUIQcnKvu0LOxLFun/jmwfs+cJnr4B1DYmctexTFrwC9D6MT4Az LwwxUBOHZUdQFdanfhKFe99BEZK8PSmTy1nvYajBSvxYU2XWP/vxkEiqTLhSZv6RXRsJtN5/JauY7 VmJ8U/eBS2oIQIZvElGl96wQhEX3gLvdlLuFiCpPzkz+A0WKBfW2ZlsEUdhQTCtG63y1TPxMBQIlW zjg6pfIUlHCZm4Upnme+xA==; In-Reply-To: <87ikxwamor.fsf_-_@gmail.com> (message from Helmut Eller on Tue, 25 Jun 2024 20:42:44 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320681 Archived-At: > From: Helmut Eller > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Tue, 25 Jun 2024 20:42:44 +0200 > > Here are some patches for this. I also have some questions: > > 1) In fix_subr, the &s->intspec.native field should only traced if the > subr is a non-primitive. Because, for primitives, it's a (possibly > non-aligned) char*. Right? > > 2) In dump_subr, the command_modes field is dumped with dump_field_lv > for non-primitives but for primitives with dump_field_emacs_ptr. > Is this intentional or a bug? > > 3) In fix_subr, why is the command_modes field only traced if > HAVE_NATIVE_COMP? (Today was the first time I heard of the > command-modes function; still have no clue what it's used for :-) Andrea, can you help with these questions?