From: Eli Zaretskii <eliz@gnu.org>
To: Sandra Snan <sandra.snan@idiomdrottning.org>,
Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 71017@debbugs.gnu.org
Subject: bug#71017: [PATCH] Flow single-paragraph messages
Date: Sun, 07 Jul 2024 08:43:57 +0300 [thread overview]
Message-ID: <86h6d13gf6.fsf@gnu.org> (raw)
In-Reply-To: <20240706204950.2437581-1-sandra.snan@idiomdrottning.org> (bug-gnu-emacs@gnu.org)
> Cc: Sandra Snan <sandra.snan@idiomdrottning.org>
> Date: Sat, 6 Jul 2024 22:49:50 +0200
> From: Sandra Snan via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> This fixes two bugs when sending RFC 2646–formatted email.
Thanks. (I also see RFC 3676 mentioned -- what is this about?)
> First, the old code didn't refill or encode the last paragraph at all
> unless there was at least one hard newline EOF.
Isn't this the documented behavior?
> But for months dogfooding those two changes, sometimes a hardwrapped
> email would still be sent. I finally managed to debug and figure it out
> and it took all day. Turns out mml just plain didn't call the
> fill-flowed-encode function if the message doesn't have any hard
> newlines (newlines with the hard text property). Well, of course a
> single-paragraph email isn't gonna have any hard newlines! But it still
> needs reflowing!
>
> So I've now changed that and updated the documentation to match those
> news semantics. I went all the way, but a possible compromise might be
> to not-flow a message that has \n\n but no hard text props, since that's
> a sign that something is wrong.
The change seems to be an incompatible behavior change, so I wonder
whether we'd need some way for users to get back old behavior. Eric,
WDYT?
I'll leave it to Eric to comment on the code changes.
next prev parent reply other threads:[~2024-07-07 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 20:23 bug#71017: fill-flowed-encode Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-30 5:44 ` Stefan Kangas
2024-06-30 8:32 ` Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-30 14:34 ` Stefan Kangas
2024-07-06 20:49 ` bug#71017: [PATCH] Flow single-paragraph messages Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 5:43 ` Eli Zaretskii [this message]
2024-07-07 8:34 ` Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 9:04 ` Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 9:16 ` Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 10:02 ` Sandra Snan via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6d13gf6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71017@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=sandra.snan@idiomdrottning.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.