From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#73018: 31.0.50; wdired + replace-regexp only modifies the visible portion of the buffer Date: Mon, 09 Sep 2024 20:13:18 +0300 Organization: LINKOV.NET Message-ID: <86h6ao7ntd.fsf@mail.linkov.net> References: <20240904.080321.1100373523429404965.enometh@meer.net> <87seug85hh.fsf@web.de> <86y147gzx0.fsf@mail.linkov.net> <874j6uz4d8.fsf@web.de> <86ed5yujq3.fsf@mail.linkov.net> <87v7z9rnrp.fsf@web.de> <87o750dats.fsf@web.de> <868qw2ruv3.fsf@mail.linkov.net> <87bk0w511c.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: Madhu , 73018@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 09 19:20:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sni3f-0006Wv-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Sep 2024 19:20:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sni3V-0006Hp-Ip; Mon, 09 Sep 2024 13:20:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sni3T-0006Gz-0l for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:19:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sni3S-00053Q-Ny for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:19:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=QZbXX/uPekAxzvrzvfrVu7ge8OlMOGetUvDS3ese+z0=; b=CC3kq3lca71dmsn967oYKYv0YCTZ2Xdk4w+hjiZpN5nH6Mp9eVEAhFJmuxftBjG+8VxtCkWLB0fKQstI00OaI1Z4856YvjoU5uU53w/XV4D5d0Y6QL3s8oby4PNM0gGnefrh8xqzOWO262PzDpnBbbQCbpEyv+FL2+6Bz2S5bcDbtduLXeQj4HUBp1wHU1oYImzOWV+FFZi5EaNlQ0T/BIGez0w61OUpjQNUMDh3o2wZj63qOGc15hVBo0rnwdXibkLhYHiWHrNvyb0tear/mwP/OsG9THgYYHhrQso6xm7s3KlWbycORox0bGSoyjgSZAt5J+2WvsOu+TrUjixncg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sni3W-0001Uv-HO for bug-gnu-emacs@gnu.org; Mon, 09 Sep 2024 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Sep 2024 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73018 X-GNU-PR-Package: emacs Original-Received: via spool by 73018-submit@debbugs.gnu.org id=B73018.17259023625686 (code B ref 73018); Mon, 09 Sep 2024 17:20:02 +0000 Original-Received: (at 73018) by debbugs.gnu.org; 9 Sep 2024 17:19:22 +0000 Original-Received: from localhost ([127.0.0.1]:33965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sni2s-0001Td-4F for submit@debbugs.gnu.org; Mon, 09 Sep 2024 13:19:22 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sni2q-0001TN-Os for 73018@debbugs.gnu.org; Mon, 09 Sep 2024 13:19:21 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 3E6B8C0003; Mon, 9 Sep 2024 17:18:48 +0000 (UTC) In-Reply-To: <87bk0w511c.fsf@web.de> (Michael Heerdegen's message of "Mon, 09 Sep 2024 16:55:59 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291516 Archived-At: > Would something like this be good? > > @@ -3740,8 +3740,12 @@ dired-isearch-search-filenames > - (isearch-search-fun-in-text-property > - (funcall orig-fun) '(dired-filename dired-symlink-filename))) > + (let ((search-fun > + (isearch-search-fun-in-text-property > + (funcall orig-fun) '(dired-filename dired-symlink-filename)))) > + (lambda (&rest args) > + (font-lock-ensure) > + (apply search-fun args)))) This will call 'font-lock-ensure' for every search hit? Wouldn't it be better to call 'font-lock-ensure' only once at the beginning of the search? > A related question is whether everybody always wants to search in > symlink targets when isearching file names in dired... I don't. Would > it be worth to add an option for that? Currently the properties are > just hardcoded. > > Then, in the above patch we could make the `font-lock-ensure' call > depend on the value of that option. Maybe not an option, but just a simple variable?