From: Juri Linkov <juri@linkov.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Madhu <enometh@meer.net>, 73018@debbugs.gnu.org
Subject: bug#73018: 31.0.50; wdired + replace-regexp only modifies the visible portion of the buffer
Date: Mon, 09 Sep 2024 20:13:18 +0300 [thread overview]
Message-ID: <86h6ao7ntd.fsf@mail.linkov.net> (raw)
In-Reply-To: <87bk0w511c.fsf@web.de> (Michael Heerdegen's message of "Mon, 09 Sep 2024 16:55:59 +0200")
> Would something like this be good?
>
> @@ -3740,8 +3740,12 @@ dired-isearch-search-filenames
> - (isearch-search-fun-in-text-property
> - (funcall orig-fun) '(dired-filename dired-symlink-filename)))
> + (let ((search-fun
> + (isearch-search-fun-in-text-property
> + (funcall orig-fun) '(dired-filename dired-symlink-filename))))
> + (lambda (&rest args)
> + (font-lock-ensure)
> + (apply search-fun args))))
This will call 'font-lock-ensure' for every search hit?
Wouldn't it be better to call 'font-lock-ensure' only once
at the beginning of the search?
> A related question is whether everybody always wants to search in
> symlink targets when isearching file names in dired... I don't. Would
> it be worth to add an option for that? Currently the properties are
> just hardcoded.
>
> Then, in the above patch we could make the `font-lock-ensure' call
> depend on the value of that option.
Maybe not an option, but just a simple variable?
next prev parent reply other threads:[~2024-09-09 17:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 2:33 bug#73018: 31.0.50; wdired + replace-regexp only modifies the visible portion of the buffer Madhu
2024-09-04 3:25 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-04 8:58 ` Madhu
2024-09-04 9:08 ` Madhu
2024-09-04 16:13 ` Juri Linkov
2024-09-05 12:12 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 16:51 ` Madhu
2024-09-05 16:51 ` Juri Linkov
2024-09-06 12:04 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-06 16:08 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 16:28 ` Juri Linkov
2024-09-09 14:55 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-09 17:13 ` Juri Linkov [this message]
2024-09-09 17:55 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-09 17:14 ` Juri Linkov
2024-09-10 6:28 ` Juri Linkov
2024-09-10 13:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-10 13:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 9:47 ` Eli Zaretskii
2024-09-15 13:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-15 15:02 ` Eli Zaretskii
2024-09-16 2:06 ` Madhu
2024-09-16 14:24 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 18:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 18:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6ao7ntd.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=73018@debbugs.gnu.org \
--cc=enometh@meer.net \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.