From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 73584@debbugs.gnu.org, Emacs-hacker2023@jovi.net
Subject: bug#73584: 29.3; read-key
Date: Wed, 02 Oct 2024 13:50:55 +0300 [thread overview]
Message-ID: <86h69u22y8.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmYwxPuzdHUSXR94ees7iv3mv0NU_d9VnJgMN_FgyJ5yA@mail.gmail.com> (message from Stefan Kangas on Wed, 2 Oct 2024 10:02:44 +0000)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 2 Oct 2024 10:02:44 +0000
> Cc: 73584@debbugs.gnu.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Date: Tue, 01 Oct 2024 13:21:11 -0500
> >> From: Devon Sean McCullough <Emacs-hacker2023@jovi.net>
> >>
> >> (read-key 0) jails Emacs in a null keymap.
> >
> > You should be able to escape the jail with ESC or C-[.
> >
> > I don't see a bug here.
>
> It would arguably be a bit nicer to signal the error early to avoid
> having to mash C-[:
Maybe. But what exactly is wrong with signaling the error from
read-key-sequence-vector, which read-key calls?
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -3307,6 +3307,8 @@ read-key
> what you want as `read-key' temporarily removes all bindings
> while calling `read-key-sequence'. If nil or unspecified, the
> only unbound fallback disabled is downcasing of the last event."
> + (or (stringp prompt)
> + (signal 'wrong-type-argument (list 'stringp prompt)))
This will signal an error if PROMPT is nil or omitted, which we
definitely must support.
> ;; This overriding-terminal-local-map binding also happens to
> ;; disable quail's input methods, so although read-key-sequence
> ;; always inherits the input method, in practice read-key does not
>
> BTW, do we have something like `cl-check-type' outside of cl-lib?
We shouldn't use any cl stuff in subr.el, surely?
next prev parent reply other threads:[~2024-10-02 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 18:21 bug#73584: 29.3; read-key Devon Sean McCullough
2024-10-02 5:58 ` Eli Zaretskii
2024-10-02 10:02 ` Stefan Kangas
2024-10-02 10:50 ` Eli Zaretskii [this message]
2024-10-02 21:47 ` Stefan Kangas
2024-10-03 6:04 ` Eli Zaretskii
2024-10-03 15:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 11:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h69u22y8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73584@debbugs.gnu.org \
--cc=Emacs-hacker2023@jovi.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.