all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Wed, 04 Dec 2024 20:57:24 +0200	[thread overview]
Message-ID: <86h67jz36z.fsf@gnu.org> (raw)
In-Reply-To: <0D278D91-4D67-4E0E-869F-6AF0A46678F7@gmail.com> (message from Yuan Fu on Wed, 4 Dec 2024 10:19:42 -0800)

> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 4 Dec 2024 10:19:42 -0800
> Cc: emacs-devel@gnu.org
> 
> 
> 
> > On Dec 3, 2024, at 5:12 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> > I don't understand" c-ts-mode.el already does
> > 
> >  (require 'treesit)
> > 
> > So what would eval-when-compile add to that?
> 
> When Emacs is built without tree-sitter, none of the treesit.c functions are available (except for treesit-ready-p). Now if this Emacs compiles c-ts-mode.el, it’ll signal undefined function error for all those functions. So we add declare-function forms for all the treesit.c functions used in c-ts-mode.el, and have to update the declare-function forms whenever we use some new treesit.c functions.
> 
> If we use eval-when-compile, we don’t need to write declare-function forms in c-ts-mode.el anymore, because treesit.el has declare-function forms for all treesit.c functions.

That's what I don't understand: how will eval-when-compile which loads
treesit.el be different from (require 'treesit) we already have in
c-ts-mode?  Don't they both load treesit.el?



  reply	other threads:[~2024-12-04 18:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03  8:30 ` Andrea Corallo
2024-12-04 18:21   ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19   ` Yuan Fu
2024-12-04 18:57     ` Eli Zaretskii [this message]
2024-12-05  6:25       ` Yuan Fu
2024-12-05  7:07         ` Eli Zaretskii
2024-12-07  1:12           ` Yuan Fu
2024-12-07  7:51             ` Eli Zaretskii
2024-12-07 13:47               ` Stefan Monnier
2024-12-08  6:39                 ` Yuan Fu
2024-12-08  7:20                   ` Eli Zaretskii
2024-12-11 23:28                     ` Andrea Corallo
2024-12-08 15:27                   ` Stefan Monnier
2024-12-09  1:37                     ` Yuan Fu
2024-12-09  2:40                       ` Stefan Monnier
2024-12-11  1:57                         ` Dmitry Gutov
2024-12-13 21:54                           ` Stefan Monnier
2024-12-08 16:01     ` Dmitry Gutov
2024-12-11 23:38       ` Andrea Corallo
2024-12-12  0:23         ` Dmitry Gutov
2024-12-12  6:05           ` Yuan Fu
2024-12-12  6:43             ` Eli Zaretskii
2024-12-13  5:01               ` Yuan Fu
2024-12-12  6:19           ` Eli Zaretskii
2024-12-12  6:13         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h67jz36z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.