From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel@gnu.org
Subject: Re: cl-defgeneric vs random funcall in project.el
Date: Fri, 31 Jul 2015 09:36:58 -0500 [thread overview]
Message-ID: <86fv44z94l.fsf@stephe-leake.org> (raw)
In-Reply-To: <55BAC366.1010803@yandex.ru> (Dmitry Gutov's message of "Fri, 31 Jul 2015 03:37:58 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 07/31/2015 02:33 AM, Stephen Leake wrote:
>
>> If the elisp project backend just used load-path as project-search-path,
>> what desired functionality would you lose?
>
> xref-find-references won't search inside the current project root.
It would help to be more specific. Since we disagree, you can't assume
I'll guess what you have in mind; my first response was "so why would
you want to?". To be truly persuasive, you need to anticipate that
response, and address it before it happens.
A concrete example directory structure:
myproj/
# contains README, some docs
.git/
# contains git repo
build/
contains Makefile, test outputs, intermediate files
lisp/
# contains *.el files
lisp-emacs-24.3/
# contains *.el files only needed with emacs 24.3
test/
# contains test drivers, known good results
The user has set load-path to (".../myproj/lisp" "~/.emacs.d/elpa/..."
".../emacs-25.0/share/..." ...)
One search the user might want to do: find the name of an elisp function
in a test driver script file, to see how it is tested, while
simultaneously finding all places that function is used in the *.el
files, to review the test cases to ensure they are sufficient.
xref-find-references should do that search.
So I agree this is a case for the user adding things to
project-search-path that are not on load-path.
It would be wrong to add the entire directory tree that contains .git;
the user is using emacs 25, so they don't want to see the emacs 24.3
files. Obviously, there is a separate case where they do want to see
those files; that's a different project configuration.
We could provide:
(defun project-create (root)
"Return a project object that has root directory ROOT.
Also enters the project in `project-root-alist'."
...)
`project-root-alist' associates root directories with project objects;
`project-current' walks up the current directory tree until it finds a
matching entry in the alist. If that fails, it tries the other methods
it currenty uses.
(defun project-add-search-path (project path)
"Add PATH (a list of directories) to `project-search-path' for PROJECT.
If the directories are relative, they are first expanded relative to
`default-directory'."
...
)
(defun project-add-search-ignore (project ignores)
"Add IGNORES (a list of shell glob patterns) to `project-ignores'
for PROJECT."
...)
Then, in the same place they add myproj/lisp to load-path, the user
adds:
(defvar my-proj (project-create ".../myproj"))
(project-add-search-path my-proj
'(".../myproj/build" ".../myproj/test"))
# ignore intermediate test files
(project-add-search-ignore my-proj '(".../myproj/build/*.temp"))
xref-find-references then searches all files in all directories on
`project-search-path' and respects `project-ignores'.
--
-- Stephe
next prev parent reply other threads:[~2015-07-31 14:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:31 cl-defgeneric vs random funcall in project.el Stephen Leake
2015-07-28 15:09 ` Dmitry Gutov
2015-07-28 23:57 ` Stefan Monnier
2015-07-29 0:16 ` Dmitry Gutov
2015-07-30 21:26 ` Stefan Monnier
2015-07-29 1:00 ` Stephen Leake
2015-07-29 1:19 ` Dmitry Gutov
2015-07-29 14:24 ` Stephen Leake
2015-07-29 19:54 ` Dmitry Gutov
2015-07-30 7:04 ` Stephen Leake
2015-07-30 11:30 ` Dmitry Gutov
2015-07-30 15:29 ` Stephen Leake
2015-07-30 15:37 ` Stephen Leake
2015-07-30 16:10 ` Dmitry Gutov
2015-07-30 23:25 ` Stephen Leake
2015-07-30 17:16 ` Dmitry Gutov
2015-07-30 23:33 ` Stephen Leake
2015-07-31 0:37 ` Dmitry Gutov
2015-07-31 14:36 ` Stephen Leake [this message]
2015-07-31 22:52 ` Dmitry Gutov
2015-08-01 10:21 ` Stephen Leake
2015-08-01 12:09 ` Dmitry Gutov
2015-08-01 14:20 ` Stephen Leake
2015-08-01 16:49 ` Dmitry Gutov
2015-08-01 19:08 ` Stephen Leake
2015-08-04 19:59 ` João Távora
2015-08-04 20:56 ` Dmitry Gutov
2015-08-04 22:43 ` João Távora
2015-08-04 23:35 ` Dmitry Gutov
2015-08-10 1:09 ` Dmitry Gutov
2015-08-10 3:07 ` Stephen Leake
2015-08-10 8:45 ` João Távora
2015-08-10 16:50 ` Stephen Leake
2015-08-10 19:38 ` João Távora
2015-08-10 18:07 ` Dmitry Gutov
2015-08-10 19:21 ` João Távora
2015-08-10 19:37 ` Dmitry Gutov
2015-08-10 19:47 ` João Távora
2015-08-10 19:55 ` Dmitry Gutov
2015-08-10 18:02 ` Dmitry Gutov
2015-08-07 15:02 ` Stefan Monnier
2015-08-07 15:32 ` Dmitry Gutov
2015-08-07 17:36 ` Stefan Monnier
2015-08-05 7:02 ` Stephen Leake
2015-07-30 21:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fv44z94l.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.