* Re: [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records.
[not found] ` <20170321202103.3FFC920EBA@vcs0.savannah.gnu.org>
@ 2017-03-21 20:32 ` Stefan Monnier
2017-03-22 5:59 ` Lars Brinkhoff
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2017-03-21 20:32 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Brinkhoff
> (url-recreate-url
> - (if (vectorp url) url
> + (if (recordp url) url
Shouldn't this use url-p ?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records.
2017-03-21 20:32 ` [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records Stefan Monnier
@ 2017-03-22 5:59 ` Lars Brinkhoff
2017-03-22 12:04 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Lars Brinkhoff @ 2017-03-22 5:59 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> (url-recreate-url
>> - (if (vectorp url) url
>> + (if (recordp url) url
>
> Shouldn't this use url-p ?
Quite possibly! I aimed to make my change in the same spirit as the
original, but I was wondering why it used vectorp all over the place.
Is there anyone in charge of this code?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records.
2017-03-22 5:59 ` Lars Brinkhoff
@ 2017-03-22 12:04 ` Stefan Monnier
2017-03-22 12:34 ` Lars Brinkhoff
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2017-03-22 12:04 UTC (permalink / raw)
To: emacs-devel
> Quite possibly! I aimed to make my change in the same spirit as the
> original, but I was wondering why it used vectorp all over the place.
> Is there anyone in charge of this code?
The last who touched it. In this case, it would be you ;-)
Another option instead of url-p is (not (stringp)).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records.
2017-03-22 12:04 ` Stefan Monnier
@ 2017-03-22 12:34 ` Lars Brinkhoff
0 siblings, 0 replies; 4+ messages in thread
From: Lars Brinkhoff @ 2017-03-22 12:34 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier wrote:
>> Quite possibly! I aimed to make my change in the same spirit as the
>> original, but I was wondering why it used vectorp all over the place.
>> Is there anyone in charge of this code?
>
> The last who touched it. In this case, it would be you ;-)
> Another option instead of url-p is (not (stringp)).
I'm fine with url-p, and make check is fine with that too.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-22 12:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170321202100.8077.56246@vcs0.savannah.gnu.org>
[not found] ` <20170321202103.3FFC920EBA@vcs0.savannah.gnu.org>
2017-03-21 20:32 ` [Emacs-diffs] scratch/record cb770f2 4/6: Make the URL library use records Stefan Monnier
2017-03-22 5:59 ` Lars Brinkhoff
2017-03-22 12:04 ` Stefan Monnier
2017-03-22 12:34 ` Lars Brinkhoff
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.