From: "Juan José García-Ripoll" <juanjose.garciaripoll@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Optional support for GDI+ on Windows (emacs-28)
Date: Tue, 31 Mar 2020 17:35:30 +0200 [thread overview]
Message-ID: <86ftdoedvh.fsf@csic.es> (raw)
In-Reply-To: 83pncs1ulv.fsf@gnu.org
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Juan José García-Ripoll
>> <juanjose.garciaripoll@gmail.com>
>> Date: Mon, 30 Mar 2020 21:26:52 +0200
>>
>> Here is a more canonical patch for the Windows port:
>
> Thanks. Was this version supposed to take care of the review
> comments to the previous one? If so, perhaps you sent the wrong
> patch, because it looks like all the issues are still there in this
> version.
Regarding your comments:
* I do not know what is supposed to replace the code regarding search
for terminal background colors. If this code is wrong, it is also
wrong in the code that uses the PNG library (src/image.c).
if (STRINGP (specified_bg)
? FRAME_TERMINAL (f)->defined_color_hook (f,
SSDATA (specified_bg),
&color,
false,
false)
: (FRAME_TERMINAL (f)->query_frame_background_color (f, &color),
true))
* Regarding the use of WCHAR in filenames, because this component only
works when GDI+ is linked in, w32_unicode_filenames is always 1 and
there is no need for additional translations.
* Regarding the use of pointers to string data, once more, I am using
the same code that is used in the image.c file to extract the image
data from the user's input. If that code is wrong, then it is so in
the PNG driver
/* Read from memory. */
tbr.bytes = SDATA (specified_data);
tbr.len = SBYTES (specified_data);
tbr.index = 0;
in the JPEG driver
jpeg_memory_src (&mgr->cinfo, SDATA (specified_data),
SBYTES (specified_data));
in the GIF driver, etc, etc.
* Regarding stylistic conventions, all have been fixed.
* Regarding the use of HAVE_NTGUI and unconditional removal of
PNG/JPEG/etc, it has been replaced with a flag HAVE_GDIPLUS which is
optionally selected at configuration time with --with-gdiplus, which
defaults to NO.
* All declarations have been changed to ANSI C99
* The static variable has to be initialized to 0 because it explicitely
describes a condition (library has not been initiated) that is
meaningful.
* I replaced the use of float with double. You might want to do the same
with nsimage.c if that is a problem.
* All fprintf() are removed except for a piece of code that is currently
commented out, but which is needed to have a look at the installed decoders.
So, what exactly is missing?
--
Juan José García Ripoll
http://juanjose.garciaripoll.com
http://quinfog.hbar.es
next prev parent reply other threads:[~2020-03-31 15:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:26 Optional support for GDI+ on Windows (emacs-28) Juan José García-Ripoll
2020-03-31 14:12 ` Eli Zaretskii
2020-03-31 15:35 ` Juan José García-Ripoll [this message]
2020-03-31 16:47 ` Eli Zaretskii
2020-03-31 16:57 ` Alan Third
2020-03-31 17:41 ` Eli Zaretskii
2020-03-31 19:36 ` Alan Third
2020-03-31 19:43 ` Stefan Monnier
2020-04-01 2:26 ` Eli Zaretskii
2020-04-01 18:33 ` Alan Third
2020-04-01 19:10 ` Eli Zaretskii
2020-03-31 17:27 ` Stefan Monnier
2020-03-31 17:52 ` Eli Zaretskii
2020-03-31 19:37 ` Stefan Monnier
2020-04-01 13:31 ` Eli Zaretskii
2020-04-01 14:58 ` Stefan Monnier
2020-04-01 15:45 ` Eli Zaretskii
2020-04-01 18:26 ` Stefan Monnier
2020-04-01 18:39 ` Juanma Barranquero
2020-04-01 19:22 ` Stefan Monnier
2020-04-01 19:24 ` Juanma Barranquero
2020-04-01 19:12 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2020-03-30 23:09 Angelo Graziosi
2020-03-31 8:02 ` Juan José García-Ripoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ftdoedvh.fsf@csic.es \
--to=juanjose.garciaripoll@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.