From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: [feature/native-comp] breakage on build Date: Tue, 02 Feb 2021 00:27:13 +0000 Message-ID: <86ft2fjov2.fsf@gmail.com> References: <87lfca7lsb.fsf@russet.org.uk> <463a837ca8ddbf7533c403350d75125d@russet.org.uk> <39105f71034e0902a749994dda9c4704@russet.org.uk> <83mtwq8kf3.fsf@gnu.org> <83k0ru8jnx.fsf@gnu.org> <83im7e8icf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:YymkPXS3B9ydpIecOGwkYUd6y6g= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 01:28:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6jYJ-0007MP-Rv for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 01:28:19 +0100 Original-Received: from localhost ([::1]:53356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6jYI-0000fj-U2 for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Feb 2021 19:28:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6jXU-0008Vm-UT for emacs-devel@gnu.org; Mon, 01 Feb 2021 19:27:29 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:52072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6jXT-0003Se-G7 for emacs-devel@gnu.org; Mon, 01 Feb 2021 19:27:28 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l6jXP-0006Ge-U5 for emacs-devel@gnu.org; Tue, 02 Feb 2021 01:27:23 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263700 Archived-At: On Sat 30 Jan 2021, akrl--- via "Emacs development discussions." wrote: > Eli Zaretskii writes: > >>> Date: Sat, 30 Jan 2021 18:38:10 +0200 >>> From: Eli Zaretskii >>> Cc: akrl@sdf.org, emacs-devel@gnu.org >>> >>> compiling to >>> c:/msys64/home/Administrator/emacs-build/build/emacs-28.0.50-snapshot-feature_native-comp-windows/native-lisp/28.0.50-x86_64-w64-mingw32-3459bc949453c7833f94b407f8ee7c17/titdic-cnv-765ac3beca7090ba17f799d9600c18e6-a5dbcc84a969a94717512a079e1cc96a.eln >>> >>> The name of that file is suspiciously close to the 260-byte limit of >>> file-name length that Win32 APIs support. So my guess is that the >>> temporary file had a few more characters (like the 6 characters which >>> replace the XXXXXX, perhaps?), and that caused the failure. >> >> Btw, Andrea: why do we need no less than 3 32-character hashes in that >> file name? With 26-byte limit on file names that libgccjit can use, >> these 96 characters use up almost half of that space, and that will >> bite us time and again down the road on MS-Windows. Can we use just >> one hash? >> > > Say ATM we have: > > native-lisp/28.0.50-x86_64-w64-mingw32-HASH1/titdic-cnv-HASH2-HASH3.eln > > - HASH1 disambiguate triplet, Emacs configuration, version etc. We can > say this is disambiguating everything that influence the ABI the eln > expects and exposes. > > - HASH2 is just hashing the full patch of the original source file. This is unclear. Did you mean the content of the source, or its filename ? > - HASH3 is hashing the content of the file. > > HASH1 is handy because one can remove selectively the eln files of say a > previous Emacs version or an old configuration. I often remove all of > these folders but the most recent one. That said technically HASH1 and > HASH3 could be merged. This should be done: it is better to simplify the filesystem layout and provide some utility functions to help with removing stale cache entries. > HASH2 is handy because there must be within this folder at most one file > with each HASH2. IOW recompiling we remove all the other .eln sharing > the same HASH2 if present as indeed these files are obsolete. So if the same source same rebuilt with different eln compile flags then only one of them is retained ? That would need to change if HASH1 and HASH3 are merged for the .eln filename. AndyM