From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Wed, 29 Dec 2021 10:17:09 +0200 Organization: LINKOV.NET Message-ID: <86fsqb4ygq.fsf@mail.linkov.net> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38771"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Sam Steingold , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 29 09:21:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2UCq-0009yN-06 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 09:21:08 +0100 Original-Received: from localhost ([::1]:54668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2UCo-0002dc-Oy for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 03:21:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2UBa-0001re-Cr for emacs-devel@gnu.org; Wed, 29 Dec 2021 03:19:50 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2UBY-0003sy-Bj for emacs-devel@gnu.org; Wed, 29 Dec 2021 03:19:49 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 2685E1C000C; Wed, 29 Dec 2021 08:19:43 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Wed, 29 Dec 2021 00:37:24 +0200") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283542 Archived-At: >> --- a/lisp/progmodes/project.el >> +++ b/lisp/progmodes/project.el >> @@ -1015,7 +1015,7 @@ if one already exists." >> - (pop-to-buffer-same-window shell-buffer) >> + (pop-to-buffer shell-buffer display-comint-buffer-action) > > Please add boundp fallbacks: project.el should retain compatibility with > older Emacs releases. Or better (bound-and-true-p display-comint-buffer-action) > +(defcustom display-comint-buffer-action 'display-buffer-same-window This default value is not what pop-to-buffer-same-window uses: (pop-to-buffer buffer display-buffer--same-window-action norecord) So for backward-compatibility the default value needs to be the same: (defcustom display-comint-buffer-action display-buffer--same-window-action that requires a different type: :type 'display-buffer--action-custom-type