From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55070: 28.1; desktop-load doesn't work in -nw (non-gui) emacs Date: Wed, 27 Apr 2022 19:53:43 +0300 Organization: LINKOV.NET Message-ID: <86fslysc14.fsf@mail.linkov.net> References: <83fsm4pbs4.fsf@gnu.org> <6961B895-263C-4632-AA4E-8DE29D6160BC@swenson.org> <83sfq3op15.fsf@gnu.org> <86wnfcxnvf.fsf@mail.linkov.net> <87mtg8i1za.fsf@gnus.org> <86h76fu9q5.fsf@mail.linkov.net> <83r15jltce.fsf@gnu.org> <86sfpzspz4.fsf@mail.linkov.net> <83o80nlnjm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: eric@swenson.org, 55070@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 27 19:03:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njl4i-00098P-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 19:03:36 +0200 Original-Received: from localhost ([::1]:37492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njl4g-0003MG-Pt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 13:03:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njkzR-0004g7-Gw for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 12:58:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njkzR-0005Dm-6I for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 12:58:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njkzR-0003vI-5q for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 12:58:09 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Apr 2022 16:58:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55070-submit@debbugs.gnu.org id=B55070.165107868615036 (code B ref 55070); Wed, 27 Apr 2022 16:58:09 +0000 Original-Received: (at 55070) by debbugs.gnu.org; 27 Apr 2022 16:58:06 +0000 Original-Received: from localhost ([127.0.0.1]:44173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njkzO-0003uL-GQ for submit@debbugs.gnu.org; Wed, 27 Apr 2022 12:58:06 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njkzK-0003sf-5u; Wed, 27 Apr 2022 12:58:03 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1AA691C0005; Wed, 27 Apr 2022 16:57:53 +0000 (UTC) In-Reply-To: <83o80nlnjm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Apr 2022 21:14:37 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230802 Archived-At: tags 55070 + patch quit >> >> ;; People don't expect emacs -nw, or --daemon, >> >> ;; to create graphical frames (bug#17693). >> >> ;; TODO perhaps there should be a separate value >> >> ;; for desktop-restore-frames to control this startup behavior? >> >> >> >> So this patch creates such separate values: >> > >> > Thanks, but I don't understand why you need the frameset part of the >> > patch. >> >> Because restoring frames on tty fails without this fix. > > Restoring frames is desktop.el's business, so it should be fixed > there. The sole purpose of frameset.el is to save and restore frames. So the bug was fixed in frameset.el. > Why does "emacs -nw" at all save frame coordinates if they > cannot be restored? "emacs -nw" doesn't save frame coordinates. >> > Or if you do need it, why does it have to look so ad-hoc? If >> > we want to support in frameset.el frames for which some frame >> > parameters make no sense, let's do that explicitly, not by sweeping >> > problems under the carpet by substituting some arbitrary values for >> > those parameters that give us trouble. >> >> These values are not arbitrary. The function frame-monitor-attributes >> used in the same fixed function frameset-move-onscreen returns on tty: >> >> ((geometry 0 0 80 23) >> (workarea 0 0 80 23)) >> >> where 'left' and 'top' values are zero. > > That is arbitrary as well. > > I hope we can find a more elegant and explicit solution to this issue. I provided the patch to fix this bug. If you know how to fix it better, this would be fine.