From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.bugs Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Date: Fri, 18 Nov 2022 21:01:54 +0100 Message-ID: <86fsegowul.fsf@gnu.org> References: <86bkp5y16y.fsf@gnu.org> <83r0y1cxyb.fsf@gnu.org> <87o7t5wlby.fsf@gmail.com> <87bkp5xl6f.fsf@dfreeman.email> <87fsehw4ze.fsf@gmail.com> <83cz9kd99x.fsf@gnu.org> <87wn7swf4e.fsf@dfreeman.email> <83zgco9vqe.fsf@gnu.org> <87bkp4wazv.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13508"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 Cc: eliz@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 21:03:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow7a1-0003M1-Ee for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 21:03:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow7Zp-0007RW-If; Fri, 18 Nov 2022 15:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow7Zn-0007Mm-O9 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow7Zn-00076B-FR for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow7Zn-0006CV-4I for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:03:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Arash Esbati Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 20:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59338 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Eli Zaretskii , arstoffel@gmail.com, bug-gnu-emacs@gnu.org, 59338@debbugs.gnu.org Original-Received: via spool by 59338-submit@debbugs.gnu.org id=B59338.166880173823671 (code B ref 59338); Fri, 18 Nov 2022 20:03:03 +0000 Original-Received: (at 59338) by debbugs.gnu.org; 18 Nov 2022 20:02:18 +0000 Original-Received: from localhost ([127.0.0.1]:38346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow7Z4-00069j-30 for submit@debbugs.gnu.org; Fri, 18 Nov 2022 15:02:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow7Z2-00069H-60 for 59338@debbugs.gnu.org; Fri, 18 Nov 2022 15:02:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow7Yw-00071r-RC; Fri, 18 Nov 2022 15:02:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rdw1Q1vbIyvdf5QGq/mV1nNZpyc9k9dr3S1t/IJyIeg=; b=alfndgxLmHY3rfKvL+Vz /vO38XOGnhggMTUuTS3hUQ73zMmC4Bg3yWkzIT4ROJXN99Djmm+s5Nkf2ZpDh1gX3Zx/rQ4rj7i/A hikNuaiWYUv3Y+RIui2fWdu7R9T90vQx7ABSdye/Fl9jvNid5Ji3xcai81s+Ehf32lOlp+pGTJ9ut 5QVbYLgG1gEsrn5b5n5Nr9LwJ3euwYNhZIAa0FqOoICSXLidtDIsOt8oRakBJSjwfyiN5iSnX6M9E KgDN4nCmahDKRj8SYnos/9cU7isbYR2zH71LQfJahiWvelB/qZFyJI/PMNKt66WLNqd/BLfJKmWyc /G1QdJA541cBcQ==; Original-Received: from p5b326552.dip0.t-ipconnect.de ([91.50.101.82] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow7Yv-00039s-N6; Fri, 18 Nov 2022 15:02:10 -0500 In-Reply-To: <87bkp4wazv.fsf@dfreeman.email> (Danny Freeman's message of "Fri, 18 Nov 2022 09:55:47 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248275 Archived-At: Danny Freeman writes: > I can confirm it works on linux, but I don't have a windows machine. > Someone else would need to verify it there. Many thanks for working on this. I tried your patch on my Windows box and this is what I get: (require 'eglot) (insert "\n" (format "%s" (eglot--path-to-uri "d:/digestif-test/tikz-test.tex"))) => file:///d%3A/digestif-test/tikz-test.tex (insert "\n" (format "%s" (eglot--path-to-uri "d:/digestif-test/tikz test.tex"))) => file:///d%3A/digestif-test/tikz%20test.tex As Eli already mentioned, %-escaping the colon seems to be wrong (I couldn't find a definitive source for this, though), but it seems a deliberate decision in eglot.el's `eglot--uri-path-allowed-chars', which also references this GitHub issue[1]. My original problem is solved and digestif-LSP works on Windows again. So for now, I suggest to apply your patch and close this report. Best, Arash Footnotes: [1] https://github.com/joaotavora/eglot/pull/639