From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62250: 29.0.60; Allow context menu from text properties to not override everything Date: Sun, 19 Mar 2023 19:43:28 +0200 Organization: LINKOV.NET Message-ID: <86fsa0r60v.fsf@mail.linkov.net> References: <87ttyixzt2.fsf@gmail.com> <865yaxq5xh.fsf@mail.linkov.net> <87cz55rjir.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11420"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62250@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 19 18:54:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdxEc-0002kO-MP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Mar 2023 18:54:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdxEN-00063m-0J; Sun, 19 Mar 2023 13:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdxEK-00062H-Dn for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 13:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdxEJ-0007qF-VI for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 13:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdxEJ-0002gR-RO for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 13:54:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 17:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62250 X-GNU-PR-Package: emacs Original-Received: via spool by 62250-submit@debbugs.gnu.org id=B62250.167924839410220 (code B ref 62250); Sun, 19 Mar 2023 17:54:03 +0000 Original-Received: (at 62250) by debbugs.gnu.org; 19 Mar 2023 17:53:14 +0000 Original-Received: from localhost ([127.0.0.1]:52691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxDW-0002el-0Z for submit@debbugs.gnu.org; Sun, 19 Mar 2023 13:53:14 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:43433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxDT-0002e8-M1 for 62250@debbugs.gnu.org; Sun, 19 Mar 2023 13:53:12 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B95151BF206; Sun, 19 Mar 2023 17:53:04 +0000 (UTC) In-Reply-To: <87cz55rjir.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Mar 2023 19:39:40 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258244 Archived-At: --=-=-= Content-Type: text/plain >> I already envisioned such request > > All right. Just for the record, this would be useful to create a > context menu for images. The patch below will allow using the text property like 'context-menu-functions '(image-context-menu) > Also, I could take advantage of it to slightly > simplify the context menu of jit-spell. Actually, flyspell was the reason why the text property `context-menu-function' overrides everything: 1. `make-flyspell-overlay' puts an overlay property (overlay-put overlay 'context-menu-function 'flyspell-context-menu) 2. `flyspell-context-menu' returns `flyspell-correct-word' 3. `context-menu-map' should return this symbol unmodified 4. at the end, the symbol `flyspell-correct-word' is executed as a command from the menu binding in `context-menu-entry' or from `context-menu-open': (if (commandp map) (call-interactively map) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=context-menu-functions.patch diff --git a/lisp/mouse.el b/lisp/mouse.el index 6b9accd6758..2cd2840bad9 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -368,9 +368,10 @@ context-menu-map the function `context-menu-filter-function'." (let* ((menu (make-sparse-keymap (propertize "Context Menu" 'hide t))) (click (or click last-input-event)) - (window (posn-window (event-start click))) - (fun (mouse-posn-property (event-start click) - 'context-menu-function))) + (start (event-start click)) + (window (posn-window start)) + (fun (mouse-posn-property start 'context-menu-function)) + (funs (mouse-posn-property start 'context-menu-functions))) (unless (eq (selected-window) window) (select-window window)) @@ -380,7 +381,9 @@ context-menu-map (run-hook-wrapped 'context-menu-functions (lambda (fun) (setq menu (funcall fun menu click)) - nil))) + nil)) + (dolist (fun funs) + (setq menu (funcall fun menu click)))) ;; Remove duplicate separators as well as ones at the beginning or ;; end of the menu. --=-=-=--