From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: "Jörg Bornemann" <foss@jbornemann.de>, 68570@debbugs.gnu.org
Subject: bug#68570: 29.1; recompile might not re-use project-compile's buffer
Date: Mon, 22 Jan 2024 09:31:22 +0200 [thread overview]
Message-ID: <86fryp7ubp.fsf@mail.linkov.net> (raw)
In-Reply-To: <60842df3-8a64-4bde-b6d6-f94b9a964a17@gutov.dev> (Dmitry Gutov's message of "Sun, 21 Jan 2024 20:33:00 +0200")
>>>> Although I'm thinking by now that it might be more consistent to have
>>>> a separate project-recompile command in addition to
>>>> recompile.
>>> I've pushed to master a new command called that (commit 0a07603ae8d), like
>>> discussed on the mailing list.
>> Shouldn't now 'g' in project buffers use 'project-recompile'?
>
> I don't know if it should - AFAICS 'M-x recompile' doesn't rename the
> current buffer, so it seems like the current behavior is already correct.
This patch would allow 'recompile' to use the renamed project compilation buffer:
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index ab4504fa027..58bf2401dac 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1395,7 +1395,10 @@ project-compile
(compilation-buffer-name-function
(or project-compilation-buffer-name-function
compilation-buffer-name-function)))
- (call-interactively #'compile)))
+ (with-current-buffer (call-interactively #'compile)
+ (when project-compilation-buffer-name-function
+ (setq-local compilation-buffer-name-function
+ project-compilation-buffer-name-function)))))
(defun project-recompile (&optional edit-command)
"Run `recompile' with appropriate buffer."
Then 'project-recompile' won't be needed anymore.
next prev parent reply other threads:[~2024-01-22 7:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 16:17 bug#68570: 29.1; recompile might not re-use project-compile's buffer Jörg Bornemann
2024-01-19 20:19 ` Pengji Zhang
2024-01-20 14:27 ` Dmitry Gutov
2024-01-21 5:09 ` Dmitry Gutov
2024-01-21 18:18 ` Juri Linkov
2024-01-21 18:33 ` Dmitry Gutov
2024-01-22 7:31 ` Juri Linkov [this message]
2024-01-22 8:42 ` Jörg Bornemann
2024-01-22 18:20 ` Dmitry Gutov
2024-01-23 7:09 ` Juri Linkov
2024-01-23 12:21 ` Dmitry Gutov
2024-01-23 13:15 ` Jörg Bornemann
2024-01-23 17:31 ` Dmitry Gutov
2024-01-24 7:46 ` Juri Linkov
2024-01-24 12:06 ` Dmitry Gutov
2024-01-24 17:11 ` Juri Linkov
2024-01-26 0:44 ` Dmitry Gutov
2024-01-27 17:53 ` Juri Linkov
2024-01-28 13:42 ` Dmitry Gutov
2024-02-06 17:39 ` Juri Linkov
2024-02-07 18:43 ` Dmitry Gutov
2024-05-02 6:16 ` Juri Linkov
2024-05-02 7:11 ` Eli Zaretskii
2024-01-22 8:39 ` Jörg Bornemann
2024-01-22 18:20 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fryp7ubp.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=68570@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=foss@jbornemann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.