From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: acm@muc.de, yantar92@posteo.net, 65451@debbugs.gnu.org
Subject: bug#65451: 30.0.50; `after-change-functions' are not triggered in the same order the changes are made
Date: Sat, 30 Mar 2024 17:11:02 +0300 [thread overview]
Message-ID: <86frw7dd3d.fsf@gnu.org> (raw)
In-Reply-To: <jwvmsqfvns7.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 30 Mar 2024 09:51:59 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Ihor Radchenko <yantar92@posteo.net>, 65451@debbugs.gnu.org, Alan
> Mackenzie <acm@muc.de>
> Date: Sat, 30 Mar 2024 09:51:59 -0400
>
> > I think Org mode is relying on something it should not. This
> > particular use case aside, Emacs is allowed to call a function that
> > changes the buffer from a function that itself changes the buffer, and
> > it is allowed to call that inner function _before_ it did all the
> > changes it intended to do.
>
> AFAIK the above sequences breaks the promise we make about
> `before-change-functions` and `after-change-functions`.
>
> Almost all the non-trivial users of those hooks (i.e. basically those
> that need to use both hooks) have extra sanity and raise the heads up in
> despair when faced with things like the above (my `track-changes.el`
> lacks such sanity checks, but that's because it's a PoC).
I still stand by my opinion: Org is relying on something it cannot
rely upon, not as long as a function that changes a buffer can be
called from another function which changes the same buffer. I don't
see how we can avoid breaking code which relies on such assumptions,
not in general anyway.
next prev parent reply other threads:[~2024-03-30 14:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 9:30 bug#65451: 30.0.50; `after-change-functions' are not triggered in the same order the changes are made Ihor Radchenko
2023-08-22 12:22 ` Eli Zaretskii
2023-08-22 12:42 ` Ihor Radchenko
2023-08-22 12:58 ` Eli Zaretskii
2023-08-22 13:41 ` Ihor Radchenko
2023-08-22 16:02 ` Eli Zaretskii
2023-08-23 8:52 ` Ihor Radchenko
2023-08-23 17:58 ` Eli Zaretskii
2023-08-24 7:46 ` Ihor Radchenko
2023-08-24 8:08 ` Eli Zaretskii
2023-08-24 11:24 ` Ihor Radchenko
2023-08-24 12:08 ` Eli Zaretskii
2023-08-24 13:27 ` Ihor Radchenko
2023-08-24 14:53 ` Eli Zaretskii
2023-08-25 6:37 ` Eli Zaretskii
2023-08-25 9:09 ` Ihor Radchenko
2023-08-26 7:10 ` Eli Zaretskii
2023-08-27 8:13 ` Ihor Radchenko
2023-08-27 8:29 ` Eli Zaretskii
2023-08-29 7:39 ` Ihor Radchenko
2023-08-25 8:09 ` Ihor Radchenko
2023-08-25 10:25 ` Eli Zaretskii
2023-08-25 10:49 ` Ihor Radchenko
2024-03-30 13:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 14:11 ` Eli Zaretskii [this message]
2024-03-30 15:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 16:47 ` Eli Zaretskii
2024-03-31 3:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 3:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 6:06 ` Eli Zaretskii
2024-03-31 13:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 18:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-08 19:10 ` Ihor Radchenko
2024-04-07 18:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86frw7dd3d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65451@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.