From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 40629706b1f 1/2: Avoid unnecessary escaping in 'url-build-query-string' Date: Tue, 23 Apr 2024 19:19:59 +0300 Message-ID: <86frvc3vbk.fsf@gnu.org> References: <171343493172.17932.11313573194838208920@vcs2.savannah.gnu.org> <20240418100853.D8466C1FB57@vcs2.savannah.gnu.org> <874jbxy073.fsf@pub.pink> <868r19bet3.fsf@gnu.org> <87h6fshxks.fsf@wibble.ilmari.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30680"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jm@pub.pink, emacs-devel@gnu.org To: Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 23 18:21:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzItQ-0007oy-PW for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Apr 2024 18:21:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzIsn-00067I-10; Tue, 23 Apr 2024 12:20:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIsU-00060q-Vj for emacs-devel@gnu.org; Tue, 23 Apr 2024 12:20:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIsT-0007Ih-JA; Tue, 23 Apr 2024 12:20:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=v21onllfRrC0TtPFCXjdauCRIgtCs+WnkywN6zLO7bA=; b=I53sBqXzyzhDsvo01njG ssn0hQEO4Auk+kWNHoTNpbYf3tO4wamW4rBcDWi+GFEvis02inBvR1IVU0vsndzB6Zmm6Gk9uDIh9 bQuWL9PPYdAlArhk5TTF1EQyTzwRJx+qfG79hB9E8hS62XXQyTwitY5Q2i6gTeugs/JCp864p3k8T CtL/HwxAIZGt4bLnZiEpKnmGCp2d8qd7PJNMSsEIO4eJcXpJDEx0B1Cm0gQswRa+9FxrA91a7wd0S rpu0ZH02J3aK1mdQ5nYrgVEuLBXcpkrPQ14ROzAQ5W5VBGelAeSvM43fcgq1iy45xXCjv7TTQjQNH 1vHlxtmOE8Q0nw==; In-Reply-To: <87h6fshxks.fsf@wibble.ilmari.org> (message from Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= on Tue, 23 Apr 2024 17:07:31 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318012 Archived-At: > From: Dagfinn Ilmari Mannsåker > Cc: john muhl , emacs-devel@gnu.org > Date: Tue, 23 Apr 2024 17:07:31 +0100 > > Eli Zaretskii writes: > > >> From: john muhl > >> Cc: Eli Zaretskii , emacs-devel@gnu.org > >> Date: Thu, 18 Apr 2024 11:01:56 -0500 > >> > >> Bisect says this commit caused the gravatar tests to start failing. > >> > >> make test/lisp/image/gravatar-tests.log > > > > Thanks. Ilmari, could you please look into this? The question is > > whether we need to adapt the gravatar tests, or fine-tune your changes > > to url-utils. > > I think the gravatar test should be adjusted. Both the old and the new > form are valid, and this over-escaping is exactly what my change was > intended to address. > > However, I appear to have exhausted the acceptable amount contribution > without doing the copyright assignment dance, which I have no time for, > so someone else will have to make the actual change. Thanks, someone already did.