From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Tue, 11 Jun 2024 09:58:19 +0300 Organization: LINKOV.NET Message-ID: <86frtkeyzo.fsf@mail.linkov.net> References: <86ikymipzx.fsf@gnu.org> <7269c7c4-86a1-44bf-8d5d-378c3584027a@gmx.at> <86zfrx8ec0.fsf@mail.linkov.net> <8561a63a-66d3-44cd-872f-73d26af7edbe@gmx.at> <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> <868qzehxie.fsf@mail.linkov.net> <86msnu9fhg.fsf@gnu.org> <86zfruc7qh.fsf@mail.linkov.net> <86ikyi9e2l.fsf@gnu.org> <86o78ac6ny.fsf@mail.linkov.net> <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27302"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , abdo.haji.ali@gmail.com, 71386@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 11 17:55:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH3q5-0006u3-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jun 2024 17:55:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH3py-0007JB-IY; Tue, 11 Jun 2024 11:55:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH3px-0007IU-3D for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 11:55:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sH3pw-00033h-GH for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 11:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sH3pu-0000na-Om for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.17181212873030 (code B ref 71386); Tue, 11 Jun 2024 15:55:02 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 11 Jun 2024 15:54:47 +0000 Original-Received: from localhost ([127.0.0.1]:35840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH3pe-0000mn-P6 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 11:54:47 -0400 Original-Received: from mslow1.mail.gandi.net ([217.70.178.240]:49713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH3pd-0000mg-EH for 71386@debbugs.gnu.org; Tue, 11 Jun 2024 11:54:45 -0400 Original-Received: from relay1-d.mail.gandi.net (unknown [217.70.183.193]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 1C68DC4E1B for <71386@debbugs.gnu.org>; Tue, 11 Jun 2024 07:11:52 +0000 (UTC) Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id AD43A240005; Tue, 11 Jun 2024 07:11:45 +0000 (UTC) In-Reply-To: <0ab646c8-ff46-4c27-acbf-b5f4b8ab06fd@gmx.at> (martin rudalics's message of "Mon, 10 Jun 2024 10:00:28 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287083 Archived-At: >> But I don't understand the logic of using the KILL argument >> in 'window--delete': >> >> (kill >> (delete-frame frame)) >> >> Maybe Martin could explain. > > KILL non-nil here comes from the prefix argument of 'quit-window' which, > if provided, 'quit-window' passes as 'kill' via BURY-OR-KILL to > 'quit-restore-window' which then passes t via the KILL argument to > 'window--delete'. 'window--delete' itself does not deal with buffers, > it handles windows only. > > 'quit-restore-window' calls 'kill-buffer' later when BURY-OR-KILL equals > 'kill'. At that time, the window should already have been taken care of > - either by deletion or by showing another buffer. The return value of > 'window--delete' is used to make the last conjuncts in the first 'cond' > of 'quit-restore-window' succeed or fail (in the latter case the next > clause will be probed). > > The idea of deleting the frame comes from the fact that a killed buffer > cannot be re-shown in that frame's sole window. 'quit-restore-window' > calls 'window--delete' in this case iff that window has no previous > other buffer to show instead, so deleting the window (and possibly its > frame) is the obvious choice rather than showing some unrelated buffer > in it. So it makes no sense to send the value of the KILL arg to tab-bar code? Because there is nothing to decide based on its value?