all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eshel Yaron <me@eshelyaron.com>
Cc: emacs-devel@gnu.org,  Dmitry Gutov <dmitry@gutov.dev>
Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too
Date: Fri, 14 Jun 2024 19:41:52 +0300	[thread overview]
Message-ID: <86frtffpdb.fsf@mail.linkov.net> (raw)
In-Reply-To: <m1tthwt1rv.fsf@dazzs-mbp.kpn> (Eshel Yaron's message of "Fri, 14 Jun 2024 09:35:32 +0200")

>> Lisp error: (wrong-type-argument number-or-marker-p nil)
>
> Hmm that's quite curious...  I can reproduce it also without my change
> in 56537ab0228, FWIW.  AFAICT the issue is that icomplete trims the
> prefix from completion candidates before passing them to
> completion-lazy-hilit, while completion--hilit-from-re expects the full
> candidate (prefix included).  I'm not deeply familiar with icomplete,
> but maybe calling completion-lazy-hilit before trimming the candidates
> as in the diff below should do the trick?

Thanks, I confirm with this change icomplete doesn't fail anymore.



  reply	other threads:[~2024-06-14 16:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org>
     [not found] ` <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org>
2024-06-13  8:20   ` master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Eshel Yaron
2024-06-13 14:11     ` Dmitry Gutov
2024-06-13 14:51       ` Eshel Yaron
2024-06-14  6:10     ` Juri Linkov
2024-06-14  7:35       ` Eshel Yaron
2024-06-14 16:41         ` Juri Linkov [this message]
2024-06-14 18:04           ` Eshel Yaron
2024-06-14 22:44             ` Dmitry Gutov
2024-06-30 16:29           ` Juri Linkov
2024-06-30 18:14             ` Eshel Yaron
2024-07-01  6:57               ` Juri Linkov
2024-07-01  8:58                 ` Eshel Yaron
2024-07-01 16:29                   ` Juri Linkov
2024-07-02 11:12                     ` Eli Zaretskii
2024-07-02 12:17                       ` Eshel Yaron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86frtffpdb.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    --cc=me@eshelyaron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.