From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>,
abdo.haji.ali@gmail.com, 71386@debbugs.gnu.org
Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs
Date: Sun, 16 Jun 2024 09:58:10 +0300 [thread overview]
Message-ID: <86frtdtlns.fsf@mail.linkov.net> (raw)
In-Reply-To: <2b0260af-82f1-4c08-9d15-dd4f3f40d13d@gmx.at> (martin rudalics's message of "Sat, 15 Jun 2024 10:42:05 +0200")
> +(defvar window-delete-frame-functions nil
> + "A list of functions to handle the frame deletion.
>
> I'd still prefer a tab-bar specific option (like 'tab-bar-save-frame-p'
> as mentioned earlier) for two reasons.
>
> The first reason is that 'window--delete' is an internal function of
> window.el. I wouldn't want an internal function run a hook "of its own"
> because that's difficult to explain to users. OTOH I suppose that a
> function like 'tab-bar-save-frame-p' should be callable from any other
> function too, as soon as the need arises.
>
> The second reason is that I wouldn't want "anyone" to inhibit frame
> deletion. Such a facility could have consequences I cannot fathom at
> the moment. Would we want 'delete-frame' to obey it too and possibly
> spare the frame?
Ok, here is the right patch:
diff --git a/lisp/window.el b/lisp/window.el
index b7bd59bc813..872110a8321 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -4120,6 +4120,8 @@ window-deletable-p
(let ((frame (window-frame window)))
(cond
+ ((and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1))
+ 'tab)
((frame-root-window-p window)
;; WINDOW's frame can be deleted only if there are other frames
;; on the same terminal, and it does not contain the active
@@ -4979,6 +4981,9 @@ window--delete
(unless (and dedicated-only (not (window-dedicated-p window)))
(let ((deletable (window-deletable-p window)))
(cond
+ ((eq deletable 'tab)
+ (tab-bar-close-tab)
+ 'tab)
((eq deletable 'frame)
(let ((frame (window-frame window)))
(cond
next prev parent reply other threads:[~2024-06-16 6:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 23:44 bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Al Haji-Ali
2024-06-06 5:45 ` Eli Zaretskii
2024-06-06 6:12 ` Juri Linkov
2024-06-06 9:20 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-06 10:10 ` Eli Zaretskii
2024-06-06 9:19 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 6:39 ` Juri Linkov
2024-06-07 8:23 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 17:20 ` Juri Linkov
2024-06-07 17:52 ` Eli Zaretskii
2024-06-07 18:16 ` Juri Linkov
2024-06-07 18:44 ` Al Haji-Ali
2024-06-09 16:59 ` Juri Linkov
2024-06-09 17:46 ` Eli Zaretskii
2024-06-09 17:58 ` Juri Linkov
2024-06-09 18:16 ` Eli Zaretskii
2024-06-09 18:28 ` Juri Linkov
2024-06-10 8:00 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-11 6:58 ` Juri Linkov
2024-06-11 16:26 ` Al Haji-Ali
2024-06-13 6:50 ` Juri Linkov
2024-06-12 8:57 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 6:53 ` Juri Linkov
2024-06-13 8:21 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-14 6:13 ` Juri Linkov
2024-06-14 17:46 ` Juri Linkov
2024-06-15 8:42 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 6:58 ` Juri Linkov [this message]
2024-06-16 7:52 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 10:50 ` Al Haji-Ali
2024-06-17 14:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 16:08 ` Al Haji-Ali
2024-06-17 16:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 17:01 ` Al Haji-Ali
2024-06-18 9:52 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-18 19:04 ` Al Haji-Ali
2024-06-19 6:24 ` Juri Linkov
2024-06-19 9:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 6:48 ` Juri Linkov
2024-06-20 9:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 16:45 ` Juri Linkov
2024-06-17 6:16 ` Juri Linkov
2024-06-17 14:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 19:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86frtdtlns.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=71386@debbugs.gnu.org \
--cc=abdo.haji.ali@gmail.com \
--cc=eliz@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.