From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Date: Sat, 22 Jun 2024 12:11:45 +0300 Message-ID: <86frt5ibou.fsf@gnu.org> References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71666@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 11:12:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKwnm-000623-Ni for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 11:12:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKwnA-0002Ro-4s; Sat, 22 Jun 2024 05:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwn0-0002Qo-2I for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 05:12:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKwmy-0004g8-AE for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 05:12:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKwmx-0000v6-VP for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 05:12:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 09:12:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71666-submit@debbugs.gnu.org id=B71666.17190475223507 (code B ref 71666); Sat, 22 Jun 2024 09:12:03 +0000 Original-Received: (at 71666) by debbugs.gnu.org; 22 Jun 2024 09:12:02 +0000 Original-Received: from localhost ([127.0.0.1]:44418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwmw-0000uR-1F for submit@debbugs.gnu.org; Sat, 22 Jun 2024 05:12:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwmt-0000u7-EN for 71666@debbugs.gnu.org; Sat, 22 Jun 2024 05:12:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwmn-0004de-Mz; Sat, 22 Jun 2024 05:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CjDgvh7hKb1Jl3Y1MzPl5rjFrdANxwF0xMB3ybRhFUA=; b=FCHscS0EradQ q7it/dfYHpI0jhx/cPeW+npnW94FEOg3sCQPk6DI9zxP0cg+6jV29rkUbONFy/9aQM1JhMQlYV8a7 JydaNat7/OoUg7nTAhOtj3fK9Y43eNdctVg8rJOUSIoowhPsAdP4btEkBE8Ds1rq7PSZ4FBTPbZOn A1k7pyOqzDHF45zgpPhnuLDY2HmEIsitT+Z0fhcs/CcfVExxY95AHGvQh0suhizn/I2wBHz9hjKJ+ L7bqx4OhsqV2C6/YxF6Pe1FnbuAAe9UwhPjR29/Un8pN3sIshrQTXz/9Gnbj1tUQj7vBSeYiV2dUF +FOaoxu/1i9/8gpH9+Avkw==; In-Reply-To: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> (message from Jim Porter on Wed, 19 Jun 2024 21:47:26 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287679 Archived-At: > Date: Wed, 19 Jun 2024 21:47:26 -0700 > From: Jim Porter > > To reproduce this, start from "emacs -Q -f eww" and then go to fsf.org. > Move point over one of the larger images on the page, like the ones that > say "Featured" above them, and press Z ('shr-zoom-image'). The result is > that the image is duplicated, and the first slice gets pushed up onto > the previous line. > > Attached is a patch to fix this, with regression tests. I tried the recipe and the patch. While the patches shr behaves better than the unpatched, I don't see the image being zoomed, it stays at its original size. Do I need some optional library or external program for the zoom to happen? Thanks.