From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71763: [PATCH] Inconsistency in bitmap overlay drawing for macOS Date: Thu, 27 Jun 2024 12:35:19 +0300 Message-ID: <86frsy684o.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71763@debbugs.gnu.org To: Daniel Pettersson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 11:36:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMlYE-0000em-FV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 11:36:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMlXt-0005a4-Kk; Thu, 27 Jun 2024 05:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMlXr-0005Zi-9J for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:35:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMlXr-0008R9-13 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:35:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMlXt-0000fc-Pl for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 09:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71763-submit@debbugs.gnu.org id=B71763.17194809322537 (code B ref 71763); Thu, 27 Jun 2024 09:36:01 +0000 Original-Received: (at 71763) by debbugs.gnu.org; 27 Jun 2024 09:35:32 +0000 Original-Received: from localhost ([127.0.0.1]:41029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMlXQ-0000eq-Gc for submit@debbugs.gnu.org; Thu, 27 Jun 2024 05:35:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMlXP-0000ec-4k for 71763@debbugs.gnu.org; Thu, 27 Jun 2024 05:35:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMlXG-0007ZL-M2; Thu, 27 Jun 2024 05:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TGbbYeGnANUQnjS5CBXgi/JuhTtuITeqe9+98/O00GM=; b=SzBEQgKNlWEk vwNiY1HooQqlADhvfnX3tNhsu1QmXCar7R/Zf1PeRSpOYUFowOHXy4RhIb4oCH77a64hhRArm22AD kTDU8wcr3oz2PHditmNIUCZBugCbfJgJuQeEBF8IRC9afBt+RmYj9U6JsaWojLyB3ZUOoY/mT0c+V 7wz38IZ8/N8RQz+PJXRfZj7dZ1SxLCuiWFz5XgUNEQdBDzE8kueqSsL8xRTuaoIsTBaSDby6hUJkP ySp1VX7xoiO5UxVQLOv0wmlM1Xw2cJCsh7DUw2gvmXqvPp0vjx7jxUQdtJbpUldiNzr5LEtDSxk3j hVVjc5w1YE5jG+QRtXveVw==; In-Reply-To: (message from Daniel Pettersson on Tue, 25 Jun 2024 00:04:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288006 Archived-At: > From: Daniel Pettersson > Date: Tue, 25 Jun 2024 00:04:27 +0200 > > On macOS overlay-arrow is not draw on top of bitmaps already present > in the fringe, like its done on X Window System (src/xterm.c). This is > to the detriment of gdb-mi.el where the overlay-arrow hides the > breakpoint when they exist on the same row. > > It can be reproduced with the following: > (require 'gdb-mi) > (defvar overlay-arrow (make-marker)) > (add-to-list 'overlay-arrow-variable-list 'overlay-arrow) > (setq fringe-indicator-alist '((overlay-arrow . hollow-right-triangle))) > (overlay-put (make-overlay (pos-bol) (1+ (pos-bol))) 'before-string > (propertize " " 'display > `(left-fringe breakpoint warning))) > (move-marker overlay-arrow (pos-bol)) > > I expect that macOS is not using overlay_p param as intended as fixed by > attached patch. But I was having an hard time finding any documentation > proving my point other then the implementation of it's X Window System > sibling in src/xterm.c. Can some macOS expert please review the proposed patch?