From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Date: Wed, 10 Jul 2024 14:16:05 +0300 Message-ID: <86frsho5u2.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72018@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 10 13:17:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRVK3-0002vE-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jul 2024 13:17:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRVJi-0003BU-0M; Wed, 10 Jul 2024 07:16:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRVJg-0003B5-1k for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 07:16:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRVJf-0004SI-Px for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 07:16:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRVJl-0004Fp-LC for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 07:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172061018316307 (code B ref 72018); Wed, 10 Jul 2024 11:17:01 +0000 Original-Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 11:16:23 +0000 Original-Received: from localhost ([127.0.0.1]:54988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRVJ9-0004Ev-9r for submit@debbugs.gnu.org; Wed, 10 Jul 2024 07:16:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRVJ7-0004ET-6d for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 07:16:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRVIu-0004ML-MH; Wed, 10 Jul 2024 07:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j1WVJikiDBbRcwfeHkzKNHn+Ghi1flgpTmZ3l5A6OYc=; b=o0jYxd4kIQsC Z5tFIa9cgVqcq+6brQ/CSzXgGn7uRBPN0k1ruZId1pUWUWHoS9Q/kHEsjqBhexSGagWD7D58bqbKe grJHNNwBVjynU/2gkUiqlApVrVSIhVEba4nhZiWRF8LQKT7CHSsvuOp5GrtBDC9LTU6ya0BKSMTey FkG6N0kJkMlIsaO+DmrzytBpr+W8ulRg800ULrzc79d855RK2ADY1C/4jOMJLOZAwJ1nxCYNhSN4I 7NFAY4v5frKEDqvGOzPkhDQBYYCYOgLYPqXoj8L3cHZ8awOVWFW1aBmRMvzDMxxWtZQitwVNfHYZV VBsOqBxDF00kwNTUvxuWRg==; In-Reply-To: (message from Jim Porter on Tue, 9 Jul 2024 11:04:05 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288669 Archived-At: > Date: Tue, 9 Jul 2024 11:04:05 -0700 > From: Jim Porter > > This is a regression from Emacs 29, likely due to some changes I made to > improve support for complex background commands. Eli, is this ok to > merge to the release branch? I don't think I understand the essence of the change, and thus cannot appreciate its effects enough to be able to answer this. What is the significance of '(car command)' in this hunk: > + ;; Reset the prompt if the command we just aborted was in the > + ;; foreground. > + (unless (car command) > + (declare-function eshell-reset "esh-mode" (&optional no-hooks)) > + (eshell-reset))))))) IOW, why '(car command)' is used as an indication of a fore/background command? Also, why does the comment say "foreground" while your text says we don't want the prompt if the killed program was in the background?