From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Date: Sun, 21 Jul 2024 09:05:24 +0300 Message-ID: <86frs3cmaj.fsf@gnu.org> References: <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, 70939-done@debbugs.gnu.org To: Ankit Gadiya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 21 08:06:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVPiF-0001Xk-So for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jul 2024 08:06:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVPhq-0005Bm-OG; Sun, 21 Jul 2024 02:06:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVPhp-0005BC-0k for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 02:06:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVPho-0005Kv-Oq for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 02:06:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVPhp-0005K0-Sc for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 02:06:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2024 06:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70939@debbugs.gnu.org, eliz@gnu.org, ankit@argp.in Original-Received: via spool by 70939-done@debbugs.gnu.org id=D70939.172154193920418 (code D ref 70939); Sun, 21 Jul 2024 06:06:01 +0000 Original-Received: (at 70939-done) by debbugs.gnu.org; 21 Jul 2024 06:05:39 +0000 Original-Received: from localhost ([127.0.0.1]:54648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVPhS-0005JG-O9 for submit@debbugs.gnu.org; Sun, 21 Jul 2024 02:05:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVPhP-0005J2-UT for 70939-done@debbugs.gnu.org; Sun, 21 Jul 2024 02:05:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVPhI-0005Iq-RX; Sun, 21 Jul 2024 02:05:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=08Xj7oOGb4WLbhYkl7Ko3LSSo6aoDdI9Vk19qt6H1ic=; b=hzFmbCFK/9x3 PpVbubas7LX+jDFquHjDat/1dJZYceOnEbZSV09XI9wwOKyMLlv4ZNy0KsjCW7YvrDAKPuIiee1+2 dGFALE5fdQIRqMQFZLaeWmo9kHGAn16wy8VCY709JHVw6Z2ifvxVnSxb1ESmCQQErzkv+xNoOlgba 69tbwmD/1jJAWorcwm/rQ913Sn3ff81Tk3f5Vr9C/SLxqljAJD7y/ocurFB4IkU/ErDEWaMOb2tgq BZVyNRgc9KPv8kSp+o+464FSD241cz7Iyi4FNvDi7/QtmsQ3/dMBi6XrMXjOZADjsV8ocTyDxTzxW mt4lS+poUGa+/+Uzpg+/3Q==; In-Reply-To: (message from Ankit Gadiya on Thu, 11 Jul 2024 13:03:32 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289057 Archived-At: > From: Ankit Gadiya > Date: Thu, 11 Jul 2024 13:03:32 +0530 > Cc: Eli Zaretskii , 70939@debbugs.gnu.org > > > I only have a few comments about the commit message: > > > > Three new commands are added in the go-ts-mode to run unit tests. > > I would just drop this line altogether, personally. > > > > (go-ts-mode-map): New map variable. > > This should probably read something like Add new bindings. > > > > (go-ts-mode-test-file): New function. > > (go-ts-mode-test-package): New function. > > These two need to be updated (...-test-this-...). > > Thanks, I'm sending the updated patch with these fixes. > > > Everything else looks good to me. Thanks for working on this, Ankit. > > > > Eli, if you have no further comments please install when you get a chance. Thanks in advance. > > Thank you for being patient through this review. After this interaction, I feel > encouraged to send more patches in the future. Now installed on the master branch, and closing the bug. Thanks.