From: Eli Zaretskii <eliz@gnu.org>
To: Ankit Gadiya <ankit@argp.in>
Cc: dev@rjt.dev, 70939-done@debbugs.gnu.org
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Date: Sun, 21 Jul 2024 09:05:24 +0300 [thread overview]
Message-ID: <86frs3cmaj.fsf@gnu.org> (raw)
In-Reply-To: <CAN7zea0EC+ce=Wc+ASM7+7y9ts__c5137ik683uT4-FTaZcZ3w@mail.gmail.com> (message from Ankit Gadiya on Thu, 11 Jul 2024 13:03:32 +0530)
> From: Ankit Gadiya <ankit@argp.in>
> Date: Thu, 11 Jul 2024 13:03:32 +0530
> Cc: Eli Zaretskii <eliz@gnu.org>, 70939@debbugs.gnu.org
>
> > I only have a few comments about the commit message:
> >
> > Three new commands are added in the go-ts-mode to run unit tests.
> > I would just drop this line altogether, personally.
> >
> > (go-ts-mode-map): New map variable.
> > This should probably read something like Add new bindings.
> >
> > (go-ts-mode-test-file): New function.
> > (go-ts-mode-test-package): New function.
> > These two need to be updated (...-test-this-...).
>
> Thanks, I'm sending the updated patch with these fixes.
>
> > Everything else looks good to me. Thanks for working on this, Ankit.
> >
> > Eli, if you have no further comments please install when you get a chance. Thanks in advance.
>
> Thank you for being patient through this review. After this interaction, I feel
> encouraged to send more patches in the future.
Now installed on the master branch, and closing the bug.
Thanks.
next prev parent reply other threads:[~2024-07-21 6:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:04 bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 16:52 ` Eli Zaretskii
2024-05-14 17:24 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 17:59 ` Eli Zaretskii
2024-05-15 2:36 ` Randy Taylor
2024-05-15 4:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 2:32 ` Randy Taylor
2024-05-16 8:27 ` Eli Zaretskii
2024-05-16 15:03 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 16:01 ` Eli Zaretskii
2024-05-18 9:54 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 2:35 ` Randy Taylor
2024-05-28 2:30 ` Randy Taylor
2024-05-28 19:58 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 18:17 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 2:40 ` Randy Taylor
2024-06-23 14:46 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 2:26 ` Randy Taylor
2024-06-26 11:27 ` Eli Zaretskii
2024-06-26 12:31 ` Randy Taylor
2024-07-06 19:44 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 22:08 ` Stefan Kangas
2024-07-06 22:30 ` Dmitry Gutov
2024-07-07 7:26 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-10 23:43 ` Randy Taylor
2024-07-11 7:33 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 14:21 ` Randy Taylor
2024-07-12 6:23 ` Eli Zaretskii
2024-07-12 11:10 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 11:21 ` Eli Zaretskii
2024-07-21 6:05 ` Eli Zaretskii [this message]
2024-06-23 14:56 ` Eli Zaretskii
2024-05-17 2:27 ` Randy Taylor
2024-05-18 8:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15 11:21 ` Eli Zaretskii
2024-05-16 1:24 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86frs3cmaj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70939-done@debbugs.gnu.org \
--cc=ankit@argp.in \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.