From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode Date: Thu, 08 Aug 2024 12:45:02 +0300 Message-ID: <86frrfmjq9.fsf@gnu.org> References: <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz> <9EE4E140-25B4-4F0D-BA28-E698BD438CF7@rnkn.xyz> <86h6bvmlwe.fsf@gnu.org> <901E6F99-1756-424F-9470-838D572D8FCF@rnkn.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34529"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72521@debbugs.gnu.org To: Paul W. Rankin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 08 11:46:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbzjV-0008pq-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Aug 2024 11:46:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbzjB-0008VF-MU; Thu, 08 Aug 2024 05:46:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbzj9-0008V4-V7 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:46:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbzj9-0006wT-MN for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=wGcc15eszO/5viwIC2f8y519KjgFI+MC9G704N6I8xo=; b=NyYCFS1Us+JK/J/y7KedATePR8mbO9DBV00Nr8s3t9XhXr7SbqHXZUO9dJt+YZnbTgCDJjStwUW7UlWY5b72QsehlAjvOIPYWaI31K5j+AiRN2L0yOoxjPobuS9KEGH6jC5hCgPMoaVZHTNLv4tTS9hT1IO+5m/A0myqjn1NvKn3sCpHhaFBpzg1ksdioDV+DHtEPplJ5ZoPm2KjFSw0v5s8PC7/WzF/+B4UtTbF1eeeyB1K4gcx1mF4piIjqiJk6G8PrL4zgzD7D5ZSkyWoVnxqGGUR4WjWkKOhW/zh+CjEH8yKTUSc0kS1S9Yo+OJD6tkQTrCPLN0mMS9E5O4UrA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbzjZ-0005Pi-Vu for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Aug 2024 09:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72521-submit@debbugs.gnu.org id=B72521.172311036420709 (code B ref 72521); Thu, 08 Aug 2024 09:47:01 +0000 Original-Received: (at 72521) by debbugs.gnu.org; 8 Aug 2024 09:46:04 +0000 Original-Received: from localhost ([127.0.0.1]:35613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbzie-0005Nv-0Q for submit@debbugs.gnu.org; Thu, 08 Aug 2024 05:46:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbzib-0005NA-6z for 72521@debbugs.gnu.org; Thu, 08 Aug 2024 05:46:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbzi5-0006s8-Fj; Thu, 08 Aug 2024 05:45:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wGcc15eszO/5viwIC2f8y519KjgFI+MC9G704N6I8xo=; b=Tpps0o3BHnI7jcLscSZx Vyvs0qFVF6UUqBSht8lC64rSurkm7r+UeLNP83NVoQGiaqGlm2Ceel3pVuOS/xM+86SV1WWlHAPC9 UGrzNw/bgTcp/+xrLHaYQMbRUNGatF9mbqSHVmBlcbwizJ4JlWyS6gCPb+8idTMNwPXK7R/9E6sWJ KXtQm8NrspJsVgsrN2xIeJdJ1SqCmL+x5kErODn39J6bR2Upz8RrMDCMJ/N2nHXxasjAiSQCY2cG1 LkbeBPnO3Sk0ccc7uDBiI18DyjYmT4lF/dE53c4otYiykxrSi4UIEN7vkLiHQwEMJ5TL8V1RNmnpF 6AQ0/wuvssSq8Q==; In-Reply-To: <901E6F99-1756-424F-9470-838D572D8FCF@rnkn.xyz> (message from Paul W. Rankin on Thu, 8 Aug 2024 19:37:56 +1000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289933 Archived-At: > From: Paul W. Rankin > Date: Thu, 8 Aug 2024 19:37:56 +1000 > Cc: 72521@debbugs.gnu.org > > > On 8 Aug 2024, at 18:58, Eli Zaretskii wrote: > > > > Thanks, but we cannot possible install this patch, since this behavior > > was introduced in Emacs 29. I agree with making this feature > > optional, of course (and it will then be ON by default), but your > > patch doesn't do that. > > Hi Eli, > > Thanks. I’ve replaced the call to variable-pitch-mode with a hook, > help-screen-hook, which defaults to calling variable-pitch-mode. > > Ideally I think this should just be help-mode-hook though, which of > course should not default to calling variable-pitch-mode. > > Anyway, how’s the patch (now attached) look to you? Looks good, but I wonder whether a simple boolean user option would be better, and also easier to customize. After all this is not a mode, so people will not expect it to have a hook. Also, if someone doesn't want variable-pitch-mode, I doubt they will want some other mode instead, so the hook will most of the time be or the default or nil. WDYT?