all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: 72735@debbugs.gnu.org
Subject: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable
Date: Wed, 21 Aug 2024 16:27:01 +0300	[thread overview]
Message-ID: <86frqyuhui.fsf@gnu.org> (raw)
In-Reply-To: <875xrvhtll.fsf@> (message from Björn Bidar on Tue, 20 Aug 2024 22:39:18 +0300)

> From: Björn Bidar <bjorn.bidar@thaodan.de>
> Cc: 72735@debbugs.gnu.org
> Date: Tue, 20 Aug 2024 22:39:18 +0300
> 
> >> +FORGE-TYPE is the type of the forge, e.g., gitlab, gitea,
> >> +sourcehut, or github.
> >
> > This leaves it unsaid how these symbols are used, and what symbols are
> > recognized.
> 
> Does the original text not say that already? The choices over all the
> existing symbols which are accepted, if it doesn't make sense to
> e.g. add a custom symbol to extend the mode than removing the (symbol)
> choice is good.

It might be enough to say that those symbols are the only predefined
ones.  The text as it is leaves the impression that they are only
examples.  Also, something should be said regarding the differences
between the symbols: why does the user need to specify these symbols
and what could happen if they use a wrong symbol?

> > Finally, I think this warrants a NEWS entry.
> 
> Should the news entry explain similarly that the variables can be set
> with defcustom and have improved documentation?

Just the fact that they are now user options, that's all.





  parent reply	other threads:[~2024-08-21 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <874j7fnr75.fsf@>
2024-08-20 17:40 ` bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-20 17:40 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-20 18:39 ` Eli Zaretskii
2024-08-20 19:39   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <875xrvhtll.fsf@>
2024-08-21 13:27     ` Eli Zaretskii [this message]
     [not found] <87a5h7hz3d.fsf@>
2024-08-20 19:04 ` Eli Zaretskii
2024-08-20 19:49   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-21  5:20   ` Tassilo Horn
2024-08-21 13:51     ` Eli Zaretskii
2024-08-20 15:34 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86frqyuhui.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72735@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.