From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Cc: emacs-devel@gnu.org
Subject: Re: smtpmail and starttls improvement when starttls program is missing
Date: Tue, 04 Nov 2008 10:50:36 -0600 [thread overview]
Message-ID: <86ej1rv3j7.fsf@lifelogs.com> (raw)
In-Reply-To: b4mzlkgfh1e.fsf@jpl.org
On Tue, 04 Nov 2008 09:53:17 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> I think `with-no-warnings' and `(require 'starttls)' are unnecessary.
KY> For `with-no-warnings', it binds `byte-compile-warnings' to nil
KY> when compiling. It is for making the byte compiler silent on any
KY> form, however there seems nothing to be warned when compiling.
KY> In addition, `with-no-warnings' is not available in Emacs 21 and
KY> XEmacs that Gnus supports, so the warning like the following is
KY> issued when compiling Gnus:
KY> While compiling the end of the data in file gnus/lisp/starttls.el:
KY> ** The function `with-no-warnings' is not known to be defined.
KY> It is not serious since the function will not be used with those
KY> versions of Emacsen, though.
OK. This was in the original code in smtpmail.el, I just moved it out
to starttls.el where it was more appropriate.
KY> For `(require 'starttls)', the reason I say it is unnecessary is
KY> that the function is defined in starttls.el that provides the
KY> `starttls' feature. ;-) Therefore the function can be rewritten
KY> like the following, isn't it?
KY> (defun starttls-any-program-available ()
KY> (let ((program (if starttls-use-gnutls
KY> starttls-gnutls-program
KY> starttls-program)))
KY> (condition-case ()
KY> (progn
KY> (call-process program)
KY> program)
KY> (error (progn
KY> (message "No STARTTLS program was available (tried '%s')"
KY> program)
KY> nil)))))
Yes, that's better, thanks. I wasn't paying attention when I copied the
code. Comitted.
Ted
prev parent reply other threads:[~2008-11-04 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:21 smtpmail and starttls improvement when starttls program is missing Ted Zlatanov
2008-10-31 17:40 ` Ted Zlatanov
2008-11-04 16:59 ` Ted Zlatanov
2008-11-04 0:53 ` Katsumi Yamaoka
2008-11-04 16:50 ` Ted Zlatanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ej1rv3j7.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.