From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: merlyn@stonehenge.com (Randal L. Schwartz) Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Sun, 25 Jul 2010 10:40:45 -0700 Message-ID: <86eier7942.fsf@red.stonehenge.com> References: <86iq4379w0.fsf@red.stonehenge.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280079658 2770 80.91.229.12 (25 Jul 2010 17:40:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 17:40:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 19:40:56 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od5C4-0005Tv-C4 for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 19:40:56 +0200 Original-Received: from localhost ([127.0.0.1]:53485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od5C3-00088z-RG for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 13:40:55 -0400 Original-Received: from [140.186.70.92] (port=34691 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od5Bw-00088E-Tg for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:40:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Od5Bv-0004wn-PF for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:40:48 -0400 Original-Received: from red.stonehenge.com ([208.79.95.2]:28151) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od5Bv-0004wa-JZ for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:40:47 -0400 Original-Received: by red.stonehenge.com (Postfix, from userid 1001) id 864933A472; Sun, 25 Jul 2010 10:40:45 -0700 (PDT) x-mayan-date: Long count = 12.19.17.10.0; tzolkin = 8 Ahau; haab = 13 Xul In-Reply-To: (Juanma Barranquero's message of "Sun, 25 Jul 2010 19:30:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127779 Archived-At: >>>>> "Juanma" == Juanma Barranquero writes: Juanma> Sure. I'd prefer to make it more portable (that already compiles on Juanma> Windows / MinGW and Ubuntu / GCC). Juanma> What is the right prototype in your system? (You didn't attach the Juanma> error output, BTW). Could you send a patch with the relevant Juanma> #ifdef? Sorry, right commit, wrong reason. Here's the error: /Users/merlyn/MIRROR/emacs-GIT/lib-src/emacsclient.c:85: error: conflicting types for 'getcwd' /usr/include/unistd.h:445: error: previous declaration of 'getcwd' was here make[2]: *** [emacsclient] Error 1 make[1]: *** [lib-src] Error 2 make: *** [bootstrap] Error 2 So it's something with: -char *(getcwd) (); +char *(getcwd) (char *, int); On BSD, the prototype is: #include char * getcwd(char *buf, size_t size); -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc. See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion