all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@stephe-leake.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: force initialization of a datatype?
Date: Sat, 07 Nov 2015 01:05:46 -0600	[thread overview]
Message-ID: <86egg2waph.fsf@stephe-leake.org> (raw)
In-Reply-To: <563C9A02.2030601@yandex.ru> (Dmitry Gutov's message of "Fri, 6 Nov 2015 14:16:02 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 11/06/2015 01:56 PM, Stephen Leake wrote:
>
>> However, `xref-find-definitions' doesn't find `make-path-iterator', and
>> there's no place to put a doc string for `make-path-iterator'.
>
> We might have to do with only documenting the related structures (and
> mentioning constructors there).
>
>> I'll see if I can fix `xref-find-definitions'.
>
> Thank you.
>
> Speaking of elisp--xref-find-definitions, you've made some additions
> to it recently.
>
> Could you remove the FIXME comment before it? It's kinda wrong.

I've had that in my local stash for a while, waiting for a significant
change to push in that file.

> Second, are you sure that elisp-xref-find-def-functions shouldn't be
> somewhere in find-func.el? 

I don't follow.

`elisp-xref-find-def-functions' is a hook that is called from
`elisp--xref-find-definitions'; why should it be in find-func?

The only file that currently puts a function on that hook is
cedet/mode-local.el; it adds similar functionality to
`help-fns-describe-function-functions' and `find-function-regexp-alist'.

> And same for the new code elisp--xref-find-definitions that supports
> structs and generics.

That code has a FIXME about moving it to
`elisp-xref-find-def-functions'; there is already code in cl-generic
that puts similar functionality on
`help-fns-describe-function-functions' and `find-function-regexp-alist'.

> I don't think we should deprecate find-func just yet, and it would
> make sense for M-x find-function to support defstruct functions and
> generics.

It does; I just tried it on some of the ones defined in
elisp-mode-tests.el.

-- 
-- Stephe



  reply	other threads:[~2015-11-07  7:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 16:28 force initialization of a datatype? Stephen Leake
2015-11-04 19:17 ` Dmitry Gutov
2015-11-06 11:56   ` Stephen Leake
2015-11-06 12:16     ` Dmitry Gutov
2015-11-07  7:05       ` Stephen Leake [this message]
2015-11-07 16:27         ` Dmitry Gutov
2015-11-07 18:30           ` Stephen Leake
2015-11-07 20:21             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86egg2waph.fsf@stephe-leake.org \
    --to=stephen_leake@stephe-leake.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.