master c8acc5fd92: Introduce a new 'inhibit-isearch' text property

master c8acc5fd92: Introduce a new 'inhibit-isearch' text property

[Juri Linkov]

@@ -3547,7 +3561,8 @@ isearch-search-string
 Optional third argument, if t, means if fail just return nil (no error).
   If not nil and not t, move to limit of search and return nil."
   (let* ((func (isearch-search-fun))
-         (pos1 (save-excursion (funcall func string bound noerror)))
+         (pos1 (save-excursion
+                 (isearch--search-skip-inhibited func string bound noerror)))
          pos2)
     (when (and
 	   ;; Avoid "obsolete" warnings for translation-table-for-input.
@@ -3570,7 +3585,8 @@ isearch-search-string
         (when translated
           (save-match-data
             (save-excursion
-              (if (setq pos2 (funcall func translated bound noerror))
+              (if (setq pos2 (isearch--search-skip-inhibited
+                              func string bound noerror))
                   (setq match-data (match-data t)))))
           (when (and pos2
                      (or (not pos1)

It would be much cleaner to implement this using isearch-filter-predicate.

Re: master c8acc5fd92: Introduce a new 'inhibit-isearch' text property

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> It would be much cleaner to implement this using isearch-filter-predicate.

Isn't that for the user to tweak?  'inhibit-isearch' expresses intention
from the person who put text into the buffer.

But I guess that would make the implementation cleaner.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c8acc5fd92: Introduce a new 'inhibit-isearch' text property

[Juri Linkov]

> Isn't that for the user to tweak?  'inhibit-isearch' expresses intention
> from the person who put text into the buffer.

'inhibit-isearch' is not different from e.g. the text property
'dired-filename' used by 'dired-isearch-filter-filenames'
via 'isearch-filter-predicate' and other similar properties.

> But I guess that would make the implementation cleaner.

Done, a cleaner implementation pushed to master.