SES case insensitive ses-jump git-pushed

SES case insensitive ses-jump git-pushed

[Vincent Belaïche]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Dear Andrés,

I have pushed the changes to the git repo.
They will be available when a new release is made or if you build from source.
Thank you very much for the suggestion and collaboration.

  Vincent.

[-- Attachment #2: Type: text/html, Size: 1211 bytes --]

Re: SES case insensitive ses-jump git-pushed

[Stefan Monnier]

> I have pushed the changes to the git repo.

I see the following warnings during compilation:

    In toplevel form:
    ses.el:115:2: Warning: custom-declare-variable `ses-jump-cell-name-function' docstring wider than 80 characters
    ses.el:126:2: Warning: custom-declare-variable `ses-jump-prefix-function' docstring wider than 80 characters
    
    In ses-jump-prefix:
    ses.el:2254:2: Warning: docstring wider than 80 characters

I also see an error when I run `make test/lisp/ses-tests`.


        Stefan

Re: SES case insensitive ses-jump git-pushed

[andrés ramírez]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lisp/ses-tests`.
    

[-- Attachment #2: thepatch --]
[-- Type: text/x-patch, Size: 2170 bytes --]

--- /home/user/downloads/opt_clone/emacs/lisp/ses.el.bak	2022-04-04 21:28:04.618636759 -0500
+++ /home/user/downloads/opt_clone/emacs/lisp/ses.el	2022-04-04 21:46:58.978592129 -0500
@@ -113,7 +113,8 @@
   :type 'hook)
 
 (defcustom ses-jump-cell-name-function 'upcase
-  "Function to process the string passed to function ‘ses-jump’. Set it to 'identity to make no change.
+  "Function to process the string passed to function ‘ses-jump’. 
+Set it to 'identity to make no change.
 Set it to 'upcase to make cell name change case isensitive.
 
  May return
@@ -124,8 +125,8 @@
   :type 'function)
 
 (defcustom ses-jump-prefix-function 'ses-jump-prefix
-  "Function that takes the prefix argument passed to function ‘ses-jump’. It may return the same
-sort of thing as ‘ses-jump-cell-name-function’."
+  "Function that takes the prefix argument passed to function ‘ses-jump’. 
+It may return the same sort of thing as ‘ses-jump-cell-name-function’."
   :group 'ses
   :type 'function)
 
@@ -2252,7 +2253,8 @@
 ;; Redisplay and recalculation
 ;;----------------------------------------------------------------------------
 (defun ses-jump-prefix (prefix-int)
-  "Convert an integer into a (ROW . COL), by numbering cells starting from 0 from top left to bottom right, going row by row."
+  "Convert an integer into a (ROW . COL), by numbering cells 
+starting from 0 from top left to bottom right, going row by row."
   (and (>= prefix-int 0)
        (<  prefix-int (* ses--numcols ses--numrows))
        (cons (/ prefix-int ses--numcols) (% prefix-int ses--numcols))))
diff -u /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el.bak /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el
--- /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el.bak	2022-04-04 22:18:44.688517086 -0500
+++ /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el	2022-04-04 22:19:05.801849579 -0500
@@ -22,6 +22,7 @@
 ;;; Code:
 
 (require 'ert)
+(require 'ert-x)
 (require 'ses)
 
 ;; Silence byte-compiler.

Diff finished.  Mon Apr  4 22:21:23 2022

Diff finished.  Mon Apr  4 22:21:23 2022

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


Best Regards

RE: SES case insensitive ses-jump git-pushed

[Vincent Belaïche]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Salut Stefan,

When I eval-buffer on ses-test.el, and then when I do M-x
ert-run-tests-interactively I get no error, the output in *ert* buffer
is as follows:

--------8<-----------8<-----------8<-----------8<-----------8<-------
Selector: t
Passed:  13
Failed:  0
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:41:09+0200
Finished.
Finished at:  2022-04-05 13:41:09+0200

.............
--------8<-----------8<-----------8<-----------8<-----------8<-------

  V.
________________________________
De : andrés ramírez <rrandresf@gmail.com>
Envoyé : mardi 5 avril 2022 05:33
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : Vincent Belaïche <vincent.b.1@hotmail.fr>; emacs-devel <emacs-devel@gnu.org>
Objet : Re: SES case insensitive ses-jump git-pushed

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lisp/ses-tests`.


[-- Attachment #2: Type: text/html, Size: 2095 bytes --]

RE: SES case insensitive ses-jump git-pushed

[Vincent Belaïche]

[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]

To be fully honest, if I M-x ert-run-tests-interactively a second time,
then I get this:

--------8<-----------8<-----------8<-----------8<-----------8<-------
Selector: t
Passed:  11
Failed:  2 (2 unexpected)
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:44:31+0200
Finished.
Finished at:  2022-04-05 13:44:31+0200

..........FF.

F ses-tests-renamed-cell-after-setting
    Check that setting A1 to 1 and A2 to (1+ A1), and then
    (ert-test-failed
     ((should
       (eq
(bound-and-true-p A2)
2))
      :form
      (eq *error* 2)
      :value nil))

F ses-tests-renamed-cells-row-insertion
    Check that setting A1 to 1 and A2 to (1+ A1), and then renaming A1 to ‘ses--foo’ and A2 to ‘ses--bar’ jumping
    (ert-test-failed
     ((should
       (eq ses--bar 2))
      :form
      (eq *error* 2)
      :value nil))
--------8<-----------8<-----------8<-----------8<-----------8<-------

It seems that the new tests are maybe not to blame, but that my existing
tests were wrong, as if there is some border effect remaining after the
tests have run, and spoiling a new test run.

  V.
________________________________
De : Vincent Belaïche <vincent.b.1@hotmail.fr>
Envoyé : mardi 5 avril 2022 13:43
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : emacs-devel <emacs-devel@gnu.org>; andrés ramírez <rrandresf@gmail.com>
Objet : RE: SES case insensitive ses-jump git-pushed

Salut Stefan,

When I eval-buffer on ses-test.el, and then when I do M-x
ert-run-tests-interactively I get no error, the output in *ert* buffer
is as follows:

--------8<-----------8<-----------8<-----------8<-----------8<-------
Selector: t
Passed:  13
Failed:  0
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:41:09+0200
Finished.
Finished at:  2022-04-05 13:41:09+0200

.............
--------8<-----------8<-----------8<-----------8<-----------8<-------

  V.
________________________________
De : andrés ramírez <rrandresf@gmail.com>
Envoyé : mardi 5 avril 2022 05:33
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : Vincent Belaïche <vincent.b.1@hotmail.fr>; emacs-devel <emacs-devel@gnu.org>
Objet : Re: SES case insensitive ses-jump git-pushed

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lisp/ses-tests`.


[-- Attachment #2: Type: text/html, Size: 4787 bytes --]

RE: SES case insensitive ses-jump git-pushed

[Vincent Belaïche]

[-- Attachment #1: Type: text/plain, Size: 3395 bytes --]

The problem might be due to this that I have several (defvar …) in the
ses-test.el, I probably added this in order to avoid some bytecompile
errors, plus somebody has added the cookie -*- lexical-binding: t; -*-
to the ses-test.el file.

SES uses buffer local variables for the cell symbols, so the interned
symbols referring to cells are per se dynamically / not lexically,
bound.

I suspect that the addition of the -*- lexical-binding: t; -*- cookies is
the root cause of the test being erroneous. If we need that cooky, then
I need another way to declare the cell symbols, maybe declaring them in
an encapsulating (let (…) …) statement and removing the (defvar …) would
solve the issue.

  V.
________________________________
De : Vincent Belaïche <vincent.b.1@hotmail.fr>
Envoyé : mardi 5 avril 2022 13:46
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : emacs-devel <emacs-devel@gnu.org>; andrés ramírez <rrandresf@gmail.com>
Objet : RE: SES case insensitive ses-jump git-pushed

To be fully honest, if I M-x ert-run-tests-interactively a second time,
then I get this:

--------8<-----------8<-----------8<-----------8<-----------8<-------
Selector: t
Passed:  11
Failed:  2 (2 unexpected)
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:44:31+0200
Finished.
Finished at:  2022-04-05 13:44:31+0200

..........FF.

F ses-tests-renamed-cell-after-setting
    Check that setting A1 to 1 and A2 to (1+ A1), and then
    (ert-test-failed
     ((should
       (eq
(bound-and-true-p A2)
2))
      :form
      (eq *error* 2)
      :value nil))

F ses-tests-renamed-cells-row-insertion
    Check that setting A1 to 1 and A2 to (1+ A1), and then renaming A1 to ‘ses--foo’ and A2 to ‘ses--bar’ jumping
    (ert-test-failed
     ((should
       (eq ses--bar 2))
      :form
      (eq *error* 2)
      :value nil))
--------8<-----------8<-----------8<-----------8<-----------8<-------

It seems that the new tests are maybe not to blame, but that my existing
tests were wrong, as if there is some border effect remaining after the
tests have run, and spoiling a new test run.

  V.
________________________________
De : Vincent Belaïche <vincent.b.1@hotmail.fr>
Envoyé : mardi 5 avril 2022 13:43
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : emacs-devel <emacs-devel@gnu.org>; andrés ramírez <rrandresf@gmail.com>
Objet : RE: SES case insensitive ses-jump git-pushed

Salut Stefan,

When I eval-buffer on ses-test.el, and then when I do M-x
ert-run-tests-interactively I get no error, the output in *ert* buffer
is as follows:

--------8<-----------8<-----------8<-----------8<-----------8<-------
Selector: t
Passed:  13
Failed:  0
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:41:09+0200
Finished.
Finished at:  2022-04-05 13:41:09+0200

.............
--------8<-----------8<-----------8<-----------8<-----------8<-------

  V.
________________________________
De : andrés ramírez <rrandresf@gmail.com>
Envoyé : mardi 5 avril 2022 05:33
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : Vincent Belaïche <vincent.b.1@hotmail.fr>; emacs-devel <emacs-devel@gnu.org>
Objet : Re: SES case insensitive ses-jump git-pushed

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lisp/ses-tests`.


[-- Attachment #2: Type: text/html, Size: 6733 bytes --]

RE: SES case insensitive ses-jump git-pushed

[Vincent Belaïche]

Dear Stefan & Glenn,

I seems that the tests fail when you run them with make + if you have an
older byte compiled ses.elc than the non-byte compiled ses.el.

I suspect that this could be fixed by some fix to Makefile.in or so.

Also I made some other changes to ses-tests.el for the sake of uniformity.

At least for me now when I run make test/lisp/ses-tests, then I get

--------8<-----------8<-----------8<-----------8<-----------8<-------
Ran 13 tests, 13 results as expected, 0 unexpected (2022-04-06 23:03:09+0200, 0.269586 sec)
--------8<-----------8<-----------8<-----------8<-----------8<-------


Thank you for your kind help.

  V.


De : andrés ramírez <rrandresf@gmail.com>
Envoyé : mardi 5 avril 2022 05:33
À : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : Vincent Belaïche <vincent.b.1@hotmail.fr>; emacs-devel <emacs-devel@gnu.org>
Objet : Re: SES case insensitive ses-jump git-pushed 
 
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lisp/ses-tests`.