From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= Newsgroups: gmane.emacs.devel Subject: Re: SES case insensitive ses-jump git-pushed Date: Tue, 05 Apr 2022 03:33:42 +0000 Organization: bien.comun.org Message-ID: <86ee2ckxux.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Vincent =?utf-8?Q?Bela=C3=AFche?= , emacs-devel To: Stefan Monnier Cancel-Lock: sha1:kQbBa156V2P1ILW4BeI4TQrI/ws= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 05 05:35:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbZz0-0001Bd-25 for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 05:35:54 +0200 Original-Received: from localhost ([::1]:54274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbZyy-0004sh-HL for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 23:35:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbZx2-00048d-3j for emacs-devel@gnu.org; Mon, 04 Apr 2022 23:33:54 -0400 Original-Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]:33748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbZx0-0000nh-Ci for emacs-devel@gnu.org; Mon, 04 Apr 2022 23:33:51 -0400 Original-Received: by mail-oo1-xc36.google.com with SMTP id w20-20020a4ae9f4000000b003243aa2c71aso2081795ooc.0 for ; Mon, 04 Apr 2022 20:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:organization:references:cancel-lock :date:message-id:mime-version; bh=aDMo6OpI0DU/FvVtxMZxSeX2mUHY1y5A0lpy3DDgojM=; b=epf3CQyw2DTj+b8m+rUBSH+b5fpyVI7MkSqIrPPykpc7ZbQ0AeKYbiXy6VAAR0YdTN GyuQMj1JeYDfdHKafh7ij6T7vkZWuReFOP60theLvH2YPX71riA8dZEk5I1lK5EIcGbO kyRPYMXvQP6Q3rDbWU+eZIi0F5YCkhhQ/BJ6h3LulhoHq7jaDHLHaY6xJGeUCXaRzChH ImfJDQnBu1MSexjJzXpR6vbvECkGlBZ2EEgI2IVRpiiqQkE0eqUm2UJDqOt5XkdDj1wx N1YN8sZGKxI0aX4NBmRzq0NsPVBhNQzl9qwFSMMBhGqMOlSU2HMzYr9I4A/XZDBXBKGI dC0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:organization :references:cancel-lock:date:message-id:mime-version; bh=aDMo6OpI0DU/FvVtxMZxSeX2mUHY1y5A0lpy3DDgojM=; b=y340exa9X7Ovjhzma1S+4V0Lx543oXye7hSduVhQEYXJbYHaNvN5Kma3BhdOpfjSXo 2WBf+fZeC3U8uugM5TsAe8WubvyCWwImZ9EGr910ujRQwH1XjE2FS/qWOztD7JhZapZU 0jVmHoHis2yTeQShaSPERy2inDl6RbZdZoZ6fZwzXQRbIGjP9vSxoB96lalQhVFkx8go 8Bi69a/L8CLu1yzYoWUHpuNQg8VpkXcEzEZjFdbqo9zaaicUi7QyHLo7mmaZCafpsiKt L9lcHr3LaxiUKxT9+RlVg6uGV9ZO5r/BhBrWismZgCFME1ctv87ePlyrQx6xyQ8BPbsY UtWg== X-Gm-Message-State: AOAM533UcgIKNk6pOGm1tqRUvma71X0qrHXB/mGsV1zf+F0jAsg60ZGZ JOIwFRCNxF3TOjDRoC9NYD0LG0Cfg2I= X-Google-Smtp-Source: ABdhPJzXy+6IbmVGwUINUo0vfAcw20e4szjdSmDvt4G43B0ro+dgIPvR2EBfx92llCZIpc6AJTFmyA== X-Received: by 2002:a4a:e1c4:0:b0:321:20f6:c4d with SMTP id n4-20020a4ae1c4000000b0032120f60c4dmr431507oot.88.1649129626339; Mon, 04 Apr 2022 20:33:46 -0700 (PDT) Original-Received: from sacsa.n800.arm.processor.yandex.fm ([190.237.25.90]) by smtp.gmail.com with ESMTPSA id q39-20020a4a88ea000000b0032165eb3af8sm4692163ooh.42.2022.04.04.20.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 20:33:45 -0700 (PDT) In-Reply-To: X-Attribution: INKA Received-SPF: pass client-ip=2607:f8b0:4864:20::c36; envelope-from=rrandresf@gmail.com; helo=mail-oo1-xc36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287787 Archived-At: --=-=-= Content-Type: text/plain >>>>> "Stefan" == Stefan Monnier writes: [...] Stefan> I also see an error when I run `make test/lisp/ses-tests`. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=case_insensitive_ses_jump.patch Content-Transfer-Encoding: quoted-printable Content-Description: thepatch --- /home/user/downloads/opt_clone/emacs/lisp/ses.el.bak 2022-04-04 21:28:0= 4.618636759 -0500 +++ /home/user/downloads/opt_clone/emacs/lisp/ses.el 2022-04-04 21:46:58.97= 8592129 -0500 @@ -113,7 +113,8 @@ :type 'hook) =20 (defcustom ses-jump-cell-name-function 'upcase - "Function to process the string passed to function =E2=80=98ses-jump=E2= =80=99. Set it to 'identity to make no change. + "Function to process the string passed to function =E2=80=98ses-jump=E2= =80=99.=20 +Set it to 'identity to make no change. Set it to 'upcase to make cell name change case isensitive. =20 May return @@ -124,8 +125,8 @@ :type 'function) =20 (defcustom ses-jump-prefix-function 'ses-jump-prefix - "Function that takes the prefix argument passed to function =E2=80=98ses= -jump=E2=80=99. It may return the same -sort of thing as =E2=80=98ses-jump-cell-name-function=E2=80=99." + "Function that takes the prefix argument passed to function =E2=80=98ses= -jump=E2=80=99.=20 +It may return the same sort of thing as =E2=80=98ses-jump-cell-name-functi= on=E2=80=99." :group 'ses :type 'function) =20 @@ -2252,7 +2253,8 @@ ;; Redisplay and recalculation ;;------------------------------------------------------------------------= ---- (defun ses-jump-prefix (prefix-int) - "Convert an integer into a (ROW . COL), by numbering cells starting from= 0 from top left to bottom right, going row by row." + "Convert an integer into a (ROW . COL), by numbering cells=20 +starting from 0 from top left to bottom right, going row by row." (and (>=3D prefix-int 0) (< prefix-int (* ses--numcols ses--numrows)) (cons (/ prefix-int ses--numcols) (% prefix-int ses--numcols)))) diff -u /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el.bak /ho= me/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el --- /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el.bak 2022-04= -04 22:18:44.688517086 -0500 +++ /home/user/downloads/opt_clone/emacs/test/lisp/ses-tests.el 2022-04-04 = 22:19:05.801849579 -0500 @@ -22,6 +22,7 @@ ;;; Code: =20 (require 'ert) +(require 'ert-x) (require 'ses) =20 ;; Silence byte-compiler. Diff finished. Mon Apr 4 22:21:23 2022 Diff finished. Mon Apr 4 22:21:23 2022 --=-=-= Content-Type: text/plain Best Regards --=-=-=--